Issue #212: Add possibility to configure alpha of description text. #213
Conversation
| @@ -82,6 +82,8 @@ | |||
| boolean cancelable = true; | |||
| boolean tintTarget = true; | |||
| boolean transparentTarget = false; | |||
| // This variable is used for configuring alpha of description text. | |||
There was a problem hiding this comment.
This comment is unnecessary
| @@ -82,6 +82,8 @@ | |||
| boolean cancelable = true; | |||
| boolean tintTarget = true; | |||
| boolean transparentTarget = false; | |||
| // This variable is used for configuring alpha of description text. | |||
| float descriptionTextAlpha = 0; | |||
There was a problem hiding this comment.
This should be initialized to 0.54f
| @@ -414,6 +416,17 @@ public TapTarget targetRadius(int targetRadius) { | |||
| return this; | |||
| } | |||
|
|
|||
| /** | |||
| * @param descriptionTextAlpha is used to define alpha of description text, should be [0..255]. | |||
| /** | ||
| * @param descriptionTextAlpha is used to define alpha of description text, should be [0..255]. | ||
| * @return TapTarget object with defined alpha for description text. | ||
| */ |
There was a problem hiding this comment.
Lets just make this comment /** Specify the alpha value [0.0, 1.0] of the description text **/
| * @param descriptionTextAlpha is used to define alpha of description text, should be [0..255]. | ||
| * @return TapTarget object with defined alpha for description text. | ||
| */ | ||
| public TapTarget descriptionTextAlpha(float descriptionTextAlpha) { |
There was a problem hiding this comment.
We should move this function to line 325
| * @return TapTarget object with defined alpha for description text. | ||
| */ | ||
| public TapTarget descriptionTextAlpha(float descriptionTextAlpha) { | ||
| if (descriptionTextAlpha < 0 || descriptionTextAlpha > 255) { |
| */ | ||
| public TapTarget descriptionTextAlpha(float descriptionTextAlpha) { | ||
| if (descriptionTextAlpha < 0 || descriptionTextAlpha > 255) { | ||
| throw new IllegalArgumentException("Alpha is out of allowed bounds"); |
There was a problem hiding this comment.
throw new IllegalArgumentException("Given an invalid alpha value: " + alpha);
| descriptionPaint.setAlpha((int) target.descriptionTextAlpha); | ||
| } else { | ||
| descriptionPaint.setAlpha((int) (0.54f * textAlpha)); | ||
| } |
There was a problem hiding this comment.
This should now just be descriptionPaint.setAlpha((int) (target.descriptionTextAlpha * textAlpha));
|
@xiphirx Thanks for the review. I made needed changes and push new commit, could you please have a look? |
|
Thanks! |
|
@xiphirx Could you please update repository on jcenter() that other developers can easily use library with latest changes? |
No description provided.