Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README and enabled Proguard code shrinking #96

Closed
wants to merge 1 commit into from
Closed

Updated README and enabled Proguard code shrinking #96

wants to merge 1 commit into from

Conversation

LukeAllen
Copy link

Changed README to give the correct setup instructions for Android Studio, including fixes for some current glitches in Android Studio. (I spent a few very frustrating hours trying to import into Eclipse as recommended by the current instructions!)

Configured proguard to shrink the code, and enabled proguard in both debug and release mode. The project was failing to run because of the Dalvik method limit as discussed here:
http://stackoverflow.com/questions/15209831/unable-to-execute-dex-method-id-not-in-0-0xffff-65536

Apparently the measurements library used in Units.java has changed, so I did a minor syntax fix there. (I'm not sure what all the .xml file changes are; I'm guessing they're automated stuff? I've mostly coded in Eclipse and not Android Studio.)

Changed README to give the correct setup instructions for Android
Studio, including fixed for some current glitches in Android Studio. (I
spent a few very frustrating hours trying to import into Eclipse as
recommended by the current instructions!)

Configured proguard to shrink the code, and enabled proguard in both
debug and release mode. The project was failing to run because of the
Dalvik method limit as discussed here:
http://stackoverflow.com/questions/15209831/unable-to-execute-dex-method-id-not-in-0-0xffff-65536

Apparently the measurements library used in Units.java has changed, so I
did a minor syntax fix there.
@LukeAllen
Copy link
Author

Actually allowing shrinking seems to have broken later parts of the app. Troubleshooting it now.

@LukeAllen
Copy link
Author

On further investigation, I don't think it's a Proguard issue; disabling shrinking doesn't change it. The two problems I'm seeing are this, with com.google.common, in debug mode:
http://stackoverflow.com/questions/16608135/android-studio-add-jar-as-library

and this, in release mode:
http://stackoverflow.com/questions/16932248/crashlytics-could-not-be-initialized-api-key-missing-from-androidmanifest-xml

Is your current code working properly for you, or are these problems in it also?

@mik3y
Copy link
Member

mik3y commented Jul 4, 2015

Sorry for neglecting this change :(

I think #104 has covered similar ground. Please open a new PR if there's something more to it -- I'll try not to sit on it for so long 🙈

@mik3y mik3y closed this Jul 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants