Skip to content

Conversation

slowsage
Copy link
Contributor

Why

This is needed since the crate name and archive prefix differ.
Related: #45

This is needed since the crate name and archive prefix differ.
@KeisukeYamashita
Copy link
Owner

KeisukeYamashita commented May 10, 2024

Thank you very much for your PR,
let me check this on the weekend!

Copy link
Owner

@KeisukeYamashita KeisukeYamashita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for your PR.

Do you have any reason why you want to add this? I don't see any errors while running cargo install or cargo binstall on my local environment:

$ cargo binstall  commitlint-rs@0.1.9 --force 
 INFO resolve: Resolving package: 'commitlint-rs@=0.1.9'
 WARN The package commitlint-rs v0.1.9 will be installed from source (with cargo)
Do you wish to continue? yes/[no]
? yes
  Downloaded commitlint-rs v0.1.9
...
   Replacing /Users/keke/.cargo/bin/commitlint
    Replaced package `commitlint-rs v0.1.10` with `commitlint-rs v0.1.9` (executable `commitlint`)
 INFO Cargo finished successfully

@slowsage
Copy link
Contributor Author

slowsage commented May 12, 2024

Weird. For me, I get:

cargo binstall  commitlint-rs@0.1.9 --force 
 INFO resolve: Resolving package: 'commitlint-rs@=0.1.9'
 WARN The package commitlint-rs v0.1.9 will be installed from source (with cargo)
  Downloaded commitlint-rs v0.1.9
  Downloaded 1 crate (25.0 KB) in 0.04s
    Updating crates.io index
  Installing commitlint-rs v0.1.9
    Updating crates.io index
   Compiling proc-macro2 v1.0.82
   Compiling unicode-ident v1.0.12
   Compiling autocfg v1.3.0
   Compiling libc v0.2.154
   Compiling memchr v2.7.2
   Compiling futures-sink v0.3.30

cargo-binstall v1.6.5

Not sure if it downloaded the binary directly from your log.
The below line (with the new Cargo.toml) will skip the compile and download the binary directly.
cargo binstall --manifest-path ./Cargo.toml commitlint-rs

Copy link
Owner

@KeisukeYamashita KeisukeYamashita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry...I misread the log and found it was trying to build it from the source.

Thank you very much, LGTM!

@KeisukeYamashita KeisukeYamashita changed the title chore(ci): Enable cargo binstall chore(other): Enable cargo binstall May 12, 2024
@KeisukeYamashita
Copy link
Owner

Let me update the scope of the PR as ci is not allowed 🙏

@KeisukeYamashita KeisukeYamashita changed the title chore(other): Enable cargo binstall chore(other): enable cargo binstall May 12, 2024
@KeisukeYamashita KeisukeYamashita merged commit 72e8f88 into KeisukeYamashita:main May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants