-
Notifications
You must be signed in to change notification settings - Fork 13
feat(.github): use docker/metadata-action
to generate tags and use cache for apk
on build
#340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>
Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>
Caution Review failedThe pull request is closed. WalkthroughRecent changes streamline the GitHub Actions workflow by removing the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- .github/workflows/release.yaml (1 hunks)
- .gitignore (1 hunks)
- Dockerfile (1 hunks)
Files skipped from review due to trivial changes (1)
- .gitignore
Additional comments not posted (2)
Dockerfile (1)
4-5
: Efficient use of caching for APK updates.The addition of cache mounts for
apk update
is a great way to optimize build times by reusing downloaded packages.Also applies to: 15-16
.github/workflows/release.yaml (1)
100-108
: Streamlined Docker image tagging withdocker/metadata-action
.The use of
docker/metadata-action@v5
for dynamic image tagging simplifies the workflow and enhances the flexibility of version tagging.
docker/metadata-action
to generate tags and use cache for apk
on builddocker/metadata-action
to generate tags and use cache for apk
on build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[actionlint] reported by reviewdog 🐶
the runner of "actions-rs/toolchain@v1" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
- uses: actions-rs/toolchain@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[actionlint] reported by reviewdog 🐶
the runner of "actions-rs/toolchain@v1" action is too old to run on GitHub Actions. update the action's version to fix this issue [action]
- uses: actions-rs/toolchain@v1 |
docker/metadata-action
to generate tags and use cache for apk
on builddocker/metadata-action
to generate tags and use cache for apk
on build
Why
To improve our CI.
Summary by CodeRabbit
New Features
Chores
.gitignore
to better support Rust development by excluding unnecessary files and directories.