Skip to content

fix(cli)!: ignore empty scope by default #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(cli)!: ignore empty scope by default #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5796acc
fix(cli)!: ignore empty scope by default
KeisukeYamashita Oct 8, 2024
27d1fe1
feat(web)!: make `ignore` default level for scope empty
KeisukeYamashita Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions src/rule/scope_empty.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ pub struct ScopeEmpty {
/// ScopeEmpty represents the scope-empty rule.
impl Rule for ScopeEmpty {
const NAME: &'static str = "scope-empty";
const LEVEL: Level = Level::Error;
const LEVEL: Level = Level::Ignore;

fn message(&self, _message: &Message) -> String {
"scope is empty".to_string()
Expand Down Expand Up @@ -79,10 +79,7 @@ mod tests {
let violation = rule.validate(&message);
assert!(violation.is_some());
assert_eq!(violation.clone().unwrap().level, Level::Error);
assert_eq!(
violation.unwrap().message,
"scope is empty".to_string()
);
assert_eq!(violation.unwrap().message, "scope is empty".to_string());
}

#[test]
Expand All @@ -101,9 +98,6 @@ mod tests {
let violation = rule.validate(&message);
assert!(violation.is_some());
assert_eq!(violation.clone().unwrap().level, Level::Error);
assert_eq!(
violation.unwrap().message,
"scope is empty".to_string()
);
assert_eq!(violation.unwrap().message, "scope is empty".to_string());
}
}
2 changes: 1 addition & 1 deletion web/src/content/docs/rules/scope-empty.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: Scope Empty
description: Check if the scope exists
---

* Default: `error`
* Default: `ignore`

## ❌ Bad

Expand Down
Loading