Skip to content

Conversation

KeisukeYamashita
Copy link
Owner

@KeisukeYamashita KeisukeYamashita commented Aug 22, 2025

Why

Because there is a case where there are no values but the rules exist.
Max length rules should bypass None which means 0.

Ref

#440
#441
#442

Summary by CodeRabbit

  • Tests
    • Added unit tests for messages missing body, scope, or type to verify no false positives and improve validation reliability.
    • Strengthens edge-case coverage and confidence in future changes without altering behavior or public interfaces.
    • Ensures consistent results across diverse inputs and safeguards against regressions.

Copy link

coderabbitai bot commented Aug 22, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds new unit tests covering no-value scenarios for BodyMaxLength, ScopeMaxLength, and TypeMaxLength rules. Each test constructs a rule with usize::MAX and a Message with None for the respective field, asserting validate returns None. No production code or public APIs changed.

Changes

Cohort / File(s) Summary
Unit tests for max-length rules
cli/src/rule/body_max_length.rs, cli/src/rule/scope_max_length.rs, cli/src/rule/type_max_length.rs
Added tests (test_no_body, test_no_scope, test_no_type) asserting no violation when corresponding Message field is None with rule length set to usize::MAX. No implementation or API changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I hop through specs with tidy cheer,
New tests nibble edges clear.
When fields are None, no flags arise—
Lengthy limits, quiet skies.
Thump, thump: green pastures draw near.

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between efaf903 and 9dca16c.

📒 Files selected for processing (3)
  • cli/src/rule/body_max_length.rs (1 hunks)
  • cli/src/rule/scope_max_length.rs (1 hunks)
  • cli/src/rule/type_max_length.rs (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add-unit-test-for-no-value-in-max-length-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@KeisukeYamashita
Copy link
Owner Author

KeisukeYamashita commented Aug 22, 2025

These unit tests should fail because of the existing issues reported by the issues:

#440
#441
#442

and should be fixed in this PR: #445

@KeisukeYamashita KeisukeYamashita marked this pull request as ready for review August 22, 2025 13:59
@KeisukeYamashita KeisukeYamashita merged commit 4f0517a into main Aug 22, 2025
11 of 13 checks passed
@KeisukeYamashita KeisukeYamashita deleted the add-unit-test-for-no-value-in-max-length-tests branch August 22, 2025 14:00
@KeisukeYamashita KeisukeYamashita changed the title chore(cli): add no value test cases for max length linters chore(cli): add no value test cases for max length rules Aug 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant