-
Notifications
You must be signed in to change notification settings - Fork 13
chore(cli): add no value test cases for max length rules #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cli): add no value test cases for max length rules #449
Conversation
Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>
Caution Review failedThe pull request is closed. WalkthroughAdds new unit tests covering no-value scenarios for BodyMaxLength, ScopeMaxLength, and TypeMaxLength rules. Each test constructs a rule with usize::MAX and a Message with None for the respective field, asserting validate returns None. No production code or public APIs changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (3)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Why
Because there is a case where there are no values but the rules exist.
Max length rules should bypass
None
which means0
.Ref
#440
#441
#442
Summary by CodeRabbit