[feature/161-orders-get] 주문 화면 조회 #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaerlo127
requested review from
sojungpp,
psyeon1120 and
JoongHyun-Kim
as code owners
chaerlo127
added
🔨 fix
sojungpp
reviewed
Mar 14, 2023
| @@ -48,7 +54,7 @@ public void cancelOrder(Long userIdx, Long orderIdx) throws BaseException{ | |||
|
|
|||
| // [판매자] 주문 상태 변경 | |||
| public void changeOrderStatus(Long userIdx, PatchOrderStatusReq patchOrderStatusReq) throws BaseException{ | |||
| User user = userRepository.findByUserIdxAndStatusEquals(userIdx, ACTIVE_STATUS).orElseThrow(() -> new BaseException(INVALID_USER_AND_STATUS)); | |||
| User user = userRepository.findByUserIdxAndStatusEquals(userIdx, ACTIVE_STATUS).orElseThrow(() -> new BaseException(INVALID_USER_IDX)); | |||
sojungpp
reviewed
Mar 14, 2023
Comment on lines
16
to
19
| Long storeIdx; | ||
| String storeName; | ||
| String accountName; | ||
| String storeAccount; |
There was a problem hiding this comment.
hoxy 이 4개 컬럼은 반복으로 출력되니까 List말고 따로 주는 건 어때용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 이슈 번호
#161
💬 기타 사항