Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/8-users-mypage] 구매자 프로필 수정 API 추가 #57

Merged
merged 3 commits into from
Jan 22, 2023

Conversation

sojungpp
Copy link
Member

📚 이슈 번호

#8

💬 기타 사항

  • none

@sojungpp sojungpp added the 🍰 feature 새로운 기능 추가 label Jan 21, 2023
@sojungpp sojungpp added this to the 1차 Sprint milestone Jan 21, 2023
@sojungpp sojungpp self-assigned this Jan 21, 2023
@sojungpp sojungpp changed the title #8 feature: 구매자 프로필 수정 API 추가 [feature/8-users-mypage] 구매자 프로필 수정 API 추가 Jan 21, 2023
Copy link
Member

@chaerlo127 chaerlo127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍀

public void modifyProfile(Long userIdx, PatchProfileReq patchProfileReq) throws BaseException{
try {
User user = userRepository.findById(userIdx).orElseThrow(() -> new BaseException(INVALID_USER_IDX));
if (patchProfileReq != null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nickname이랑 profileImg 각각 null 체크하는 게 어떨까용??
둘 중 하나만 수정할 경우에는 null 체크해서 not null인 것만 수정하면 좋을 것 같아요!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오좋아용 변경했습니다-!

@sojungpp sojungpp merged commit ec4195a into develop Jan 22, 2023
@sojungpp sojungpp linked an issue Jan 30, 2023 that may be closed by this pull request
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 feature 새로운 기능 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Users API
4 participants