fixed small % values in OneDrive usage report being shown as no data #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knightian
commented
Sep 6, 2022
| @@ -24,7 +24,7 @@ export const CellProgressBar = ({ value, reverse = false }) => { | |||
| color = 'success' | |||
| } | |||
| } | |||
| if (value) { | |||
| if (value > 0) { | |||
There was a problem hiding this comment.
This was needed because value can now be 2 decimal places.
So whilst 0 == false, 0.00 != false thus 0.00 was being treated as a value, although now I reflect on it in hindsight, 0% is a value right? (Not using any space == 0%) So shouldn't we be showing an empty percentage bar for 0% instead of "No data" 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self explanatory, see #cipp-issues in Discord for discussion