Added TenantDefaultTimezone #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can use a seperate datalist, or add an object to languageList.json, and then add 'externalSource' as an object in standards.json. If you want, I can accept this PR and do that for you. |
|
Please do =) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI for KelvinTegelaar/CIPP-API#753
The Input/Output is similar to https://github.com/open-networks/go-msgraph/blob/dd4cea7265c7e244f97c2979127fafed63142e04/supportedTimeZones.go#L82-L240
However i did notice
(UTC-08:00) Pacific Time (US & Canada)is not accepted since its(UTC-08:00) Pacific Time (US and Canada)You CAN use
UTC, but the output is(UTC) Coordinated Universal Timewhich would result in the script trying to update the timezone every 3 hours.I made Copilot create a Select for the list, but then i realized its 150 objects, which i'm not sure if we should include in the standards.json
(Maybe we should have a TimeZone list which we can query since it most likely accepts the same input?)