Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFA report update & UI tweaks #2728

Merged
merged 4 commits into from
Jul 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/views/cipp/Setup.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ const Setup = () => {
type="text"
name="TenantID"
label="Tenant ID"
placeholder="Enter the Tenant ID. e.g. mymsp.onmicrosoft.com. Leave blank to retain a previous key if this exists."
placeholder="Enter the Tenant ID. e.g. 1111-1111-1111-1111-11111. Leave blank to retain a previous key if this exists."
/>
</CCol>
</CRow>
Expand Down
12 changes: 11 additions & 1 deletion src/views/cipp/app-settings/SettingsTenants.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { useLazyGenericGetRequestQuery } from 'src/store/api/app.js'
import React, { useEffect, useRef } from 'react'
import { ModalService, TenantSelectorMultiple } from 'src/components/utilities/index.js'
import { setCurrentTenant } from 'src/store/features/app.js'
import { CAlert, CButton, CCallout, CSpinner, CTooltip } from '@coreui/react'
import { CButton, CSpinner, CTooltip } from '@coreui/react'
import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
import {
faCheckCircle,
Expand Down Expand Up @@ -261,6 +261,16 @@ export function SettingsTenants() {
modalMessage:
'Are you sure you want to reset the CPV permissions for these tenants? (This will delete the Service Principal and re-add it.)',
},
{
label: 'Remove Tenant',
modal: true,
modalType: 'POST',
modalUrl: `/api/ExecRemoveTenant`,
modalBody: {
TenantID: '!customerId',
},
modalMessage: 'Are you sure you want to remove this tenant?',
},
],
},
isModal: true,
Expand Down
17 changes: 16 additions & 1 deletion src/views/identity/reports/MFAReport.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { useSelector } from 'react-redux'
import { cellBooleanFormatter, CellTip } from 'src/components/tables'
import { CippPageList } from 'src/components/layout'
import { Row } from 'react-bootstrap'
import { cellGenericFormatter } from 'src/components/tables/CellGenericFormat'

const columns = [
{
Expand Down Expand Up @@ -57,9 +58,23 @@ const columns = [
selector: (row) => row['CoveredByCA'],
name: 'Enforced via Conditional Access',
sortable: true,
cell: (row) => CellTip(row['CoveredByCA']),
cell: cellGenericFormatter(),
exportSelector: 'CoveredByCA',
},
{
selector: (row) => row['MFAMethods'],
name: 'MFA Methods',
sortable: true,
cell: cellGenericFormatter(),
exportSelector: 'MFAMethods',
},
{
selector: (row) => row['CAPolicies'],
name: 'CA Policies',
sortable: true,
cell: cellGenericFormatter(),
exportSelector: 'CAPolicies',
},
]

const Altcolumns = [
Expand Down
Loading