Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localstorage(clear) and amend results callout #659

Merged
merged 17 commits into from
Jan 22, 2022

Conversation

AdamWillford
Copy link
Contributor

No description provided.

@homotechsual
Copy link
Contributor

Check fail is not an issue.

Update UI on Edit User and Edit Group to match revamped Edit Tenant.
Copy link
Contributor

@gavsto gavsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearing the entire local storage will remove theme preferences and potentially other things put in the state later down the line. See https://developer.mozilla.org/en-US/docs/Web/API/Storage/removeItem for how to remote an item by key.

@KelvinTegelaar
Copy link
Owner

Clearing the entire local storage will remove theme preferences and potentially other things put in the state later down the line. See https://developer.mozilla.org/en-US/docs/Web/API/Storage/removeItem for how to remote an item by key.

Agreed, we do use this in the clear cache, as that button is more a "Nuke all" situation, which can also be useful in updates where the state needs to be reset. Check out clearing a specific object instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants