Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial fixes #25

Draft
wants to merge 1 commit into
base: 1.19
Choose a base branch
from
Draft

Initial fixes #25

wants to merge 1 commit into from

Conversation

PapiOphidian
Copy link

This PR is a draft for now because it removes some mod compatibility mixins and doesn't 100% work all the time.

I believe the only issues remaining is that the FallingBlockEntity gives some issues and can cause a crash.

Chests also automatically close after a seemingly random amount of time. It's possible it's just double chests. I tested some other inventories like single chests and barrels and no issues seemingly.

I do need your help on this since I am only a beginner on mc modding and a lot of my stuff could be wrong or done better. I've just mostly done blanket fixes.

@PapiOphidian
Copy link
Author

PapiOphidian commented May 1, 2023

It looks like chests automatically closing is coming from this line:

if (!this.world.isClient && this.currentScreenHandler != null && !this.currentScreenHandler.canUse(this)) {
	this.closeHandledScreen();
	this.currentScreenHandler = this.playerScreenHandler;
}

Although it perplexes me since this should not be run in the case of chests unless the screen handler is being updated with one that can't be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant