[16.0] account_avatax_oca: Add Avatax retail price #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be moved to account_avatax_exemption
ChrisOForgeFlow
force-pushed
the
16.0-fix-avatax-retail-price
branch
from
7104459 to
1a9ab77
Compare
ChrisOForgeFlow
force-pushed
the
16.0-fix-avatax-retail-price
branch
from
1a9ab77 to
6777c27
Compare
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-account_product_fiscal_classification Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-account_product_fiscal_classification/
Currently translated at 100.0% (59 of 59 strings) Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-account_product_fiscal_classification Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-account_product_fiscal_classification/it/
Currently translated at 100.0% (59 of 59 strings) Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-account_product_fiscal_classification Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-account_product_fiscal_classification/sv/
- In a context of product creation, if classification is not provided (in import context for exemple),
link the products to an existing classification, if the taxes match an existing one.
If no classification match, try to create a new classification, based on the product fiscal settings.
(It will fail if user is not member of Accountant group that can create / write on fiscal classifications)
- In a context of product update, apply same logic, linking to existing classification, or creating new classification
This will fix current limitation if account_product_fiscal_classification and pos_sale (for exemple) is installed,
there is an error when making an update, because loading data / demo is failing for the time being if the fields
taxes_id or supplier_taxes_id is defined. See for exemple : pos_sale.default_downpayment_product that contains
{'taxes_id': '[(5,)]'} write.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-account_avatax_oca Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-account_avatax_oca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-account_product_fiscal_classification Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-account_product_fiscal_classification/
Currently translated at 100.0% (34 of 34 strings) Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-account_avatax_sale_oca Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-account_avatax_sale_oca/it/
Currently translated at 100.0% (38 of 38 strings) Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-l10n_eu_oss_oca Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-l10n_eu_oss_oca/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-l10n_eu_oss_oca Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-l10n_eu_oss_oca/
We found a bug where the price when the decimal accuracy was 5, the price would be automatically reset to the pricelist price after saving the order. The reason was a wrong implementation of onchange_reset_avatax_amount. In this test we demonstrate that the error does not happen anymore.
We have observed that when we change the Product Unit of Measure to 5 decimals, and we have a pricelist in the product, when the price is manually set by the user and the order is saved, the price is reset to the product pricelist price. The reason is that the change made to order_line during the onchange_reset_avatax_amount in the sale.order. In order to fix this, we do not change the order_line during the onchange_reset_avatax_amount in sale.order, but at the time of saving, in the write method.
Currently translated at 100.0% (39 of 39 strings) Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-l10n_eu_oss_oca Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-l10n_eu_oss_oca/it/
…xternal dependecy MT-6753
Currently translated at 100.0% (83 of 83 strings) Translation: account-fiscal-rule-16.0/account-fiscal-rule-16.0-account_avatax_exemption_base Translate-URL: https://translation.odoo-community.org/projects/account-fiscal-rule-16-0/account-fiscal-rule-16-0-account_avatax_exemption_base/it/
ChrisOForgeFlow
force-pushed
the
16.0-fix-avatax-retail-price
branch
from
6777c27 to
f6ed244
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: OCA#294