Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added speed task #70

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Added speed task #70

merged 3 commits into from
Jan 22, 2024

Conversation

KennethEnevoldsen
Copy link
Owner

Added two speed tasks one for GPU and one for CPU

Copy link
Collaborator

@x-tabdeveloping x-tabdeveloping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor comments and questions.

src/seb/registered_tasks/speed.py Outdated Show resolved Hide resolved
src/seb/registered_tasks/speed.py Outdated Show resolved Hide resolved
@@ -88,7 +88,7 @@ def evaluate(self, model: Encoder) -> TaskResult:
scores = scores.get(split, scores)
score_is_nested = isinstance(scores[next(iter(scores.keys()))], dict)
if not score_is_nested:
_scores = {lang: scores for lang in self.languages}
_scores: dict[str, dict[str, Union[float, str]]] = {lang: scores for lang in self.languages}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this to appease the type checker?

@KennethEnevoldsen KennethEnevoldsen merged commit d192e44 into main Jan 22, 2024
6 checks passed
@KennethEnevoldsen KennethEnevoldsen deleted the add-speed-task branch January 22, 2024 10:52
@KennethEnevoldsen KennethEnevoldsen mentioned this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants