Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

30 passwordless #45

Closed
wants to merge 2 commits into from
Closed

30 passwordless #45

wants to merge 2 commits into from

Conversation

nalinihar
Copy link

By Hari

@KentonWhite
Copy link
Owner

It is a nice refactoring and happy to merge in based on that alone. Don't see how it solves the problem of passwordless login to PostgreSQL as discussed here. @krlmlr does this address the problems you were seeing?

For the refactoring, could you apply it uniformly in R/sql.reader.R?

@krlmlr
Copy link
Collaborator

krlmlr commented Feb 15, 2014

@nalinihar: Are you going to work on this branch, or do you just want to have this merged into master? In the former case, @KentonWhite and myself will be happy to review your changes made on top of mine; otherwise, please consider installing this branch using

devtools::install_github("johnmyleswhite/ProjectTemplate@30-passwordless")

with the most recent version of devtools.

@krlmlr
Copy link
Collaborator

krlmlr commented Jun 3, 2014

Will reopen as appropriate.

@krlmlr krlmlr closed this Jun 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nalinihar @KentonWhite @krlmlr