Findbaddata #25
Merged
Findbaddata #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barentsen
requested changes
Oct 17, 2019
k2mosaic/mosaic.py
Outdated
| @@ -115,7 +115,7 @@ def add_pixels(self, tpf): | |||
| idx = self.cadenceno - tpfdata["CADENCENO"][0] | |||
|
|
|||
| # When time is nan, we know that there is no available data. | |||
There was a problem hiding this comment.
One minor suggestion: let's update the comment to explain the new statement, e.g.:
Suggested change
| # When time is nan, we know that there is no available data. | |
| # When quality flag 65536 is raised, there is no data and the times are NaN. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
K2mosaic was balking at a particular tpf that has all the time values set to nan but valid fluxes. THerefore I have changed the bad data identification test to look for QUALITY flags including 65536 ("no data") instead of looking for instances of time == NAN. This seems to work now. You can merge this PR instead of the previous one if you like.