Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape colon in job name #22

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Escape colon in job name #22

merged 2 commits into from
Sep 26, 2023

Conversation

Kesin11
Copy link
Owner

@Kesin11 Kesin11 commented Sep 25, 2023

Mermaid gantt rely on ":" character, so mermaid syntax will broken if job name or step name has ":".
We should escape ":" by removing them.

@Kesin11 Kesin11 added the bug Something isn't working label Sep 25, 2023
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Kesin11 Kesin11 force-pushed the replace_colon_in_job_name branch from 80d45bf to b3c55e4 Compare September 26, 2023 03:54
@github-actions

This comment has been minimized.

@Kesin11 Kesin11 force-pushed the replace_colon_in_job_name branch from b3c55e4 to e4de062 Compare September 26, 2023 03:57
@github-actions
Copy link

Code Metrics Report

main (48cf6f9) #22 (3350b9b) +/-
Coverage 0.0% 0.0% 0.0%
Test Execution Time 18s 1s -17s
Details
  |                     | main (48cf6f9) | #22 (3350b9b) | +/-  |
  |---------------------|----------------|---------------|------|
  | Coverage            |           0.0% |          0.0% | 0.0% |
  |   Files             |              0 |             0 |    0 |
  |   Lines             |              0 |             0 |    0 |
  |   Covered           |              0 |             0 |    0 |
+ | Test Execution Time |            18s |            1s | -17s |

dist_size

main (48cf6f9) #22 (3350b9b) +/-
post.js 1306950byte 1307041byte 91byte
main.js 55byte 55byte 0byte

Reported by octocov

@Kesin11 Kesin11 changed the title Replace colon in job name Escape colon in job name Sep 26, 2023
@Kesin11 Kesin11 marked this pull request as ready for review September 26, 2023 04:01
@Kesin11 Kesin11 merged commit 0e7e02f into main Sep 26, 2023
@Kesin11 Kesin11 deleted the replace_colon_in_job_name branch September 26, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant