Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit duration sec for waiting runner step in < GHES v3.9 #27

Merged
merged 6 commits into from
Sep 28, 2023

Conversation

Kesin11
Copy link
Owner

@Kesin11 Kesin11 commented Sep 28, 2023

GET workflow_job API response does not contain created_at field in GHES v3.8, it is added from GHES v3.9.

So it is not possible to calculate the elapsed time the runner is waiting for a job, actions-timeline inserts a dummy step instead.

@Kesin11 Kesin11 added the bug Something isn't working label Sep 28, 2023
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

Code Metrics Report

main (7651d9f) #27 (f451105) +/-
Coverage 0.0% 0.0% 0.0%
Test Execution Time - 2s +2s
Details
  |                     | main (7651d9f) | #27 (f451105) | +/-  |
  |---------------------|----------------|---------------|------|
  | Coverage            |           0.0% |          0.0% | 0.0% |
  |   Files             |              0 |             0 |    0 |
  |   Lines             |              0 |             0 |    0 |
  |   Covered           |              0 |             0 |    0 |
- | Test Execution Time |              - |            2s |  +2s |

dist_size

main (7651d9f) #27 (f451105) +/-
main.js 55byte 55byte 0byte
post.js 1307793byte 1308378byte 585byte

Reported by octocov

@Kesin11 Kesin11 marked this pull request as ready for review September 28, 2023 15:11
@Kesin11 Kesin11 merged commit ffc0ec1 into main Sep 28, 2023
@Kesin11 Kesin11 deleted the disable_queued_time_ghes_38 branch September 28, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant