Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integrate test at release workflow #352

Merged
merged 2 commits into from
Jan 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 5 additions & 17 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,24 +34,12 @@
path: junit

cli_test:
strategy:
matrix:
container_tag:
# - "current"
- "lts"
- "22"
fail-fast: false

runs-on: ubuntu-latest
container:
image: "node:${{ matrix.container_tag }}"

steps:
- uses: actions/checkout@v4
- name: Show node env
run: |
node -v
npm -v
- run: npm ci
- run: npm run build
- run: npm run integrate_test
- uses: earthly/actions-setup@v1.0.13

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'Node CI' step
Uses Step
uses 'earthly/actions-setup' with ref 'v1.0.13', not a pinned commit hash
with:
version: latest
github-token: ${{ secrets.GITHUB_TOKEN }}
- run: earthly +integrate-test
8 changes: 4 additions & 4 deletions Earthfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,17 @@ build:
RUN npm run build
SAVE ARTIFACT dist/ dist

integate-test:
integrate-test:
FROM +build
COPY --dir integrate_tests __tests__ .
COPY --dir integrate_tests tests .
RUN rm -rf dist
COPY +build/dist dist

RUN npm run integrate_test

# Test publishing from local purpose
prepublish:
BUILD +integate-test
BUILD +integrate-test
LOCALLY
RUN rm -rf dist
COPY +build/dist dist
Expand All @@ -36,7 +36,7 @@ prepublish:
RUN npm install && npx -y jsr publish

publish:
BUILD +integate-test
BUILD +integrate-test
LOCALLY
ARG --required VERSION
RUN rm -rf dist
Expand Down
Loading