Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networking package #18

Draft
wants to merge 9 commits into
base: dev/1.21
Choose a base branch
from
Draft

Networking package #18

wants to merge 9 commits into from

Conversation

TexBlock
Copy link
Contributor

@TexBlock TexBlock commented Oct 19, 2024

impl only on fabric side

@TexBlock TexBlock added the enhancement New feature or request label Oct 19, 2024
@AmarokIce AmarokIce marked this pull request as ready for review October 25, 2024 10:39
@AmarokIce
Copy link
Contributor

no problem with the code, but the problem with the target needs to be added

@RawDiamondMC RawDiamondMC marked this pull request as draft November 16, 2024 07:19
github-actions bot and others added 4 commits November 16, 2024 07:20
…21-networking

# Conflicts:
#	networking/neo/src/main/java/band/kessoku/lib/impl/networking/neoforge/CommonPacketsImplNeoForge.java
@AmarokIce AmarokIce marked this pull request as ready for review November 17, 2024 08:54
@AmarokIce AmarokIce marked this pull request as draft November 17, 2024 08:56
@AmarokIce
Copy link
Contributor

AmarokIce commented Nov 17, 2024

now that both NeoForge and Fabric are using the vanilla approach, I don't think we need to register KLib's packet processor or any bearer via a mixin, instead of a registry
i thinks we need to devote more attention to solving the networking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants