Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Display header buttons on hover #341

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Conversation

mintaka2479
Copy link
Contributor

Enabling many features will fill the header with buttons.
スクリーンショット 2024-06-02 9 28 15

If you do not use the header function, you do not need to display it.
Modify to display buttons on hover similar to MUI Data Grid.

2024-06-02.9.23.31.mov

Copy link

vercel bot commented Jun 2, 2024

@mintaka2479 is attempting to deploy a commit to the Kevin Vandy OSS Team on Vercel.

A member of the Team first needs to authorize it.

@KevinVandy
Copy link
Owner

I like this UI, but would like if this was an opt-in behavior with an enable*? option

@alessandrojcm
Copy link
Collaborator

I like this UI, but would like if this was an opt-in behavior with an enable*? option

Agree, I think it would be a bit of a breaking change as users expect the old behaviour.

@mintaka2479
Copy link
Contributor Author

You’ve added an option, but you’re unsure if the name is appropriate.
The option is called “enableHeaderActionsWhenHovered.”
Additionally, you’ve created a Storybook for testing purposes.

@KevinVandy KevinVandy merged commit 8c07c3e into KevinVandy:v2 Jun 13, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants