-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site maintenance #182
Site maintenance #182
Conversation
- remove <Image> it is unsupported in .md files - fix avatar api url
✅ Deploy Preview for keebfolio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hej @swift502 - thanks a lot for you efforts 🎉 We‘ll look at it soon 😊 |
After further research the search functionality could be done with Pagefind, which has good integration with astro. |
For the image optimization and loading jitter:
- name: Boston
type: pcb, case
tags: 120%, usb-c, STM32F072CBU6
link: https://github.com/bluepylons/Boston
image: boston.jpg # Images would be made local, so they can be optimized during build Separate data and html that way. Just a few proposals. But I can't find an easy way to improve the images without removing the simplicity of people being able to just add a line on Github, check the md preview to see if everything is correct and create a PR. That is a really good thing that allows people to contribute easily. |
@swift502 Wow many thanks for this big help. Here my questions (you can open a issue or pr for each one):
|
Do you have an MDX example? For me it's fine if the images are not correct if viewed on GitHub. The website should be the main way to view the content. The YAML looks clean and gives a good overview of the document structure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the code and the preview.
Looks good to me.
Many many thanks for that PR. ❤️
@BenRoe Awesome! I agree I can make other PRs for the other features.
We would just replace | [Alps Switch Opener](/keyboard/link) | <Image src='/image/path.jpg' width='200px' /> |
In terms of maintenance and code complexity, there would be more code to generate html from the yml data.
@BenRoe I actually think MDX is a good first upgrade. We can think about the more complex yml later if necessary. I'll work on a MDX version. 👍 |
I'd love to implement PageFind, it's free and statically built. Should be great.
I was getting "too many requests" errors already, so I don't know if I wanna mess with the avatar list. I just fixed this iteration of it for now. |
@BenRoe Just an update. I tried really hard to think of something elegant for the thumbnails but can't. I really don't think either is a good idea so I'm out for now, sorry. |
|
Hi. I wanted to fix the missing images, but when I saw that the site is using Astro 1 I updated everything to current versions.
This is totally unsolicited so I understand if you refuse these changes. However I'd be happy to further fix issues that might come up when building or deploying the site.
Entries cleanup
Site maintenance
<Image>
component usage because according to https://docs.astro.build/en/guides/images/#images-in-markdown-files the component is not supported in md files, and actually in the two entries where it was used it was breaking the width of the entire table column. It could potentially be implemented with mdx if we wanted image thumbnails, preventing load jitter, and get better image preview functionality.Differences
Let me know what you think. 👌