removed duplicated ifdef #1
Conversation
|
@lalalademaxiya1 is the firmware for 101 fully up to date in this repo? When I flash the via firmware it doesn't look correct with the provided json from the website.
|
|
@akash329d Hi, May i know where you got the json file? About keyboard rev_0101 we haven't released any json file yet. |
@lalalademaxiya1 https://www.keychron.com/pages/how-to-use-via-to-pair-with-keychron-q1 and https://www.keychron.com/blogs/archived/how-to-reset-your-keychron-q1-to-factory-settings The knob version is rev_0101 right? |
|
@akash329d The knob version is not applicable for rev_0101, You can try the JSON file in the link below, Written specifically for rev_0101 but not yet released. https://github.com/Keychron/keyboards/tree/master/src/keychron/q1 Thank you! |
Great, thank you so much! If the knob version is not applicable for rev_0101, what is 0101 meant for? I assumed that was for the knob verison. |
|
@akash329d The Q1 knob version firmware on our website is named keyboard rev_0107 and based on MCU stm32l432kbu6. It is NOT applicable for the hardward you have, which is named Keyboard rev_0101 and based on MCU atmega32u4 even though it supports encoder EC11. |
* sn32: revamp the shared RGB driver * split the rgb logic state config for NPN/PNP on the non-PWM side of the rgb matrix * update ROW2COL, cleanup high/low logic * bump the counter after the scan * remove atomic blocks these are not needed for SN32 * formatting * only reset the counter on wraparound * fix stray bracket * ROW2COL: offset cols before the RGB scan * software pwm control * fix row2col b/g swap * make it build * some pwm updates * simplify the soft pwm * small cleanup * software pwm: move the gpio status change in the handler * more driver updates * fix out of bounds bug * fix one side of the indexing * sw pwm: update the handlers * software rgb: full color output * row2col index fixup: attempt Keychron#1 * Revert "row2col index fixup: attempt Keychron#1" don't drink and code kids This reverts commit b61bf61. * fixup led indexes * circumvent stupid hardware decisions thanks evision * sw pwm: adjust period based on brightness * minor fixup * sw row2col: keep led rows as output * Revert "sw pwm: adjust period based on brightness" not having a period big enough for the whole matrix pass is not a good idea. cols/rows end up not getting scanned and stay dark This reverts commit e2e2a03. * actually disable the b/g channels * only check for OOB access in software COL2ROW this fixes indexing issues and things are now inline * prettify and lint it
There was a duplicated line in keyboards/keychron/q1/rev_0101/rev_0101.c that caused compilation to fail with a "unterminated #ifdef" error.