Dnsbug #6
Merged
Dnsbug #6
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 1.0.1
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a DNS-related bug in the ACME CA Plugin by improving how the Common Name (CN) is extracted from X.509 subject strings. Previously, simple string replacement could fail when subjects contained additional fields beyond the domain, causing issues during ACME DNS validation.
- Replaced string replacement logic with regex-based extraction in
ExtractDomainFromSubject - Added proper error handling for subjects without a valid CN field
- Updated CHANGELOG for version 1.0.2
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CHANGELOG.md | Documents the DNS bug fix in version 1.0.2 release notes |
| AcmeCaPlugin/AcmeCaPlugin.cs | Implements regex-based CN extraction to properly handle multi-field X.509 subjects |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # v1.0.2 | ||
| * Fix DNS issue when fields outside domain are in the subject | ||
|
|
||
| # v1.0.1 |
There was a problem hiding this comment.
Inconsistent markdown formatting: This header has a leading space before the # which breaks markdown formatting. It should be # v1.0.1 without the leading space to match the format of other headers.
Suggested change
| # v1.0.1 | |
| # v1.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug with dns