Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0.1 #19

Merged
merged 71 commits into from
Jan 23, 2025
Merged
Changes from 1 commit
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
0101f52
add comments
dgaley Jun 30, 2023
f2b8ea9
package reference
dgaley Jun 30, 2023
23a2c5e
Merge pull request #4 from Keyfactor/main
dgaley Jun 30, 2023
c94f7d9
Change status codes to EndEntityStatus codes
dgaley Jul 11, 2023
813a0a8
If digicert returns multiple identical certs (same order/cert ID pair…
dgaley Jul 11, 2023
1b3ceb0
Renew/reissue check added, parameter data types specified
dgaley Jul 26, 2023
4f08099
Don't throw exceptions when unable to retreive product IDs
dgaley Aug 22, 2023
94a7cb2
Prevent duplicate certs from syncing
dgaley Aug 23, 2023
4008aee
Update generated README
Aug 23, 2023
ab2e402
Error update
dgaley Oct 16, 2023
c363177
Merge branch 'renewcheck' of https://github.com/Keyfactor/digicert-ce…
dgaley Oct 16, 2023
a9d979b
update package reference and object names
dgaley Nov 16, 2023
8c59dae
Remove unused cert-store-merge step
fiddlermikey Nov 16, 2023
bf52f55
readme update
dgaley Jan 2, 2024
98ad090
Update generated README
Jan 2, 2024
768ab96
fix unit conversion
dgaley Jan 2, 2024
cfb4979
Merge branch 'renewcheck' of https://github.com/Keyfactor/digicert-ce…
dgaley Jan 2, 2024
6730074
Merge pull request #3 from Keyfactor/renewcheck
dgaley Jan 4, 2024
48a3fe7
Add Enabled config flag
dgaley Mar 11, 2024
61fd7e0
Update CertCentralCAConnector.cs
dgaley Mar 11, 2024
33ab07c
Merge pull request #6 from Keyfactor/skipvalidation
dgaley Mar 11, 2024
ac791a7
Port sync CA filter from DCOM gateway
dgaley Apr 19, 2024
f4bd0b7
Merge pull request #7 from Keyfactor/syncfilter
dgaley Apr 19, 2024
5bd813c
Project rename
dgaley Apr 19, 2024
eaf1549
Merge pull request #8 from Keyfactor/rename
dgaley Apr 19, 2024
b2e4493
Directory/solution rename
dgaley Apr 19, 2024
96d6b23
Update generated README
Apr 19, 2024
fc1cfb8
Merge pull request #9 from Keyfactor/rename
dgaley Apr 19, 2024
222f5fa
readme fixes
dgaley May 8, 2024
805fe93
Update generated README
May 8, 2024
ed77ae2
Readme updates
dgaley May 30, 2024
efa4d62
Merge branch '2.0' of https://github.com/Keyfactor/digicert-certcentr…
dgaley May 30, 2024
6f96cdb
readme fix
dgaley May 30, 2024
91922a4
Update generated README
May 30, 2024
48c12bf
package updates
dgaley May 30, 2024
92785c2
Merge branch '2.0' of https://github.com/Keyfactor/digicert-certcentr…
dgaley May 30, 2024
6d113d0
update manifest
dgaley May 30, 2024
726f581
Update generated README
May 30, 2024
24a2761
Update CHANGELOG.md
fiddlermikey May 30, 2024
d1b8e47
update workflow to bootstrap
May 30, 2024
57e83a4
Update generated README
May 30, 2024
9e2667a
update type, prep for catalog update
Jun 3, 2024
37737c8
Update generated README
Jun 3, 2024
a9b9e32
minor update to integration name
Jun 3, 2024
e0ada65
Merge branch '2.0' of https://github.com/Keyfactor/digicert-certcentr…
Jun 3, 2024
c019e4c
Update generated README
Jun 3, 2024
fa61e0b
Fix md rendering (#10)
fiddlermikey Jun 4, 2024
8ff0de5
update readme
dgaley Jun 6, 2024
a8b3f0b
Update generated README
Jun 6, 2024
1b36df1
Merge pull request #11 from Keyfactor/readme
dgaley Jun 6, 2024
98de45a
readme updates
dgaley Jun 6, 2024
0c2383f
Merge branch 'readme' of https://github.com/Keyfactor/digicert-certce…
dgaley Jun 6, 2024
bd0041e
Update generated README
Jun 6, 2024
b58f803
Merge pull request #12 from Keyfactor/readme
dgaley Jun 6, 2024
4eeac33
2.0 release (#5)
dgaley Jun 12, 2024
697ba54
nuget package reference version rollback
dgaley Jun 12, 2024
eb4978e
Merge branch 'release-2.0' into 2.0
fiddlermikey Jun 12, 2024
23d5c82
2.0.0 Initial Release (#14)
fiddlermikey Jun 12, 2024
f72904c
Fix merge conflict to main
Jun 12, 2024
eff9de9
clean up merge, remove old package reference
Jun 12, 2024
30a8f8e
add syncfilter config options to annotations
dgaley Aug 28, 2024
3362b99
Merge pull request #15 from Keyfactor/syncfilter-config
dgaley Aug 28, 2024
ed28ee0
Merge branch 'release-2.0' into 2.0
dgaley Aug 28, 2024
a662443
log subject and sans on enroll call
dgaley Dec 20, 2024
4c1e853
Merge pull request #17 from Keyfactor/logging
dgaley Dec 20, 2024
d565d2f
add check for "dnsname" type SANs
dgaley Jan 16, 2025
6e02da8
Merge pull request #18 from Keyfactor/sanfix
dgaley Jan 16, 2025
d091629
Update CHANGELOG.md
dgaley Jan 23, 2025
c4bc256
Update CHANGELOG.md
doebrowsk Jan 23, 2025
7dd3e56
Merge pull request #16 for release 2.0.1
doebrowsk Jan 23, 2025
69211ee
Merge branch 'main' into release-2.0
doebrowsk Jan 23, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Project rename
dgaley committed Apr 19, 2024

Verified

This commit was signed with the committer’s verified signature.
Lord-Kamina Gregorio Litenstein
commit 5bd813c95ac16cda3f41e1e8e93060d49b2148c1
2 changes: 1 addition & 1 deletion digicert-certcentral-anycagateway.sln
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 17
VisualStudioVersion = 17.6.33815.320
MinimumVisualStudioVersion = 10.0.40219.1
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "digicert-certcentral-anycagateway", "digicert-certcentral-anycagateway\digicert-certcentral-anycagateway.csproj", "{434D1E74-8EE7-4CC6-BAEC-62D224022F5F}"
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "digicert-certcentral-caplugin", "digicert-certcentral-anycagateway\digicert-certcentral-caplugin.csproj", "{434D1E74-8EE7-4CC6-BAEC-62D224022F5F}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
4 changes: 2 additions & 2 deletions digicert-certcentral-anycagateway/API/CertCentralAPIBase.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Keyfactor.Extensions.CAGateway.DigiCert.Models;
using Keyfactor.Extensions.CAPlugin.DigiCert.Models;
using Newtonsoft.Json;

using System;
@@ -7,7 +7,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.API
namespace Keyfactor.Extensions.CAPlugin.DigiCert.API
{
public abstract class CertCentralBaseResponse
{
2 changes: 1 addition & 1 deletion digicert-certcentral-anycagateway/API/CertificateChain.cs
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.API
namespace Keyfactor.Extensions.CAPlugin.DigiCert.API
{
public class CertificateChainRequest : CertCentralBaseRequest
{
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
using System.Threading.Tasks;
using System.Web;

namespace Keyfactor.Extensions.CAGateway.DigiCert.API
namespace Keyfactor.Extensions.CAPlugin.DigiCert.API
{
/// <summary>
/// Request to get the details for a specific certificate type.
2 changes: 1 addition & 1 deletion digicert-certcentral-anycagateway/API/CertificateTypes.cs
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.API
namespace Keyfactor.Extensions.CAPlugin.DigiCert.API
{
/// <summary>
/// Request to get a certificate type.
2 changes: 1 addition & 1 deletion digicert-certcentral-anycagateway/API/CheckDCV.cs
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.API
namespace Keyfactor.Extensions.CAPlugin.DigiCert.API
{
public class DVCheckDCVRequest : CertCentralBaseRequest
{
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.API
namespace Keyfactor.Extensions.CAPlugin.DigiCert.API
{
public class DownloadCertificateByFormatRequest : CertCentralBaseRequest
{
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Keyfactor.Extensions.CAGateway.DigiCert.Models;
using Keyfactor.Extensions.CAPlugin.DigiCert.Models;
using Newtonsoft.Json;

using System;
@@ -8,7 +8,7 @@
using System.Threading.Tasks;
using System.Web;

namespace Keyfactor.Extensions.CAGateway.DigiCert.API
namespace Keyfactor.Extensions.CAPlugin.DigiCert.API
{
public class ListCertificateOrdersRequest : CertCentralBaseRequest
{
2 changes: 1 addition & 1 deletion digicert-certcentral-anycagateway/API/ListContainers.cs
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.API
namespace Keyfactor.Extensions.CAPlugin.DigiCert.API
{
/// <summary>
/// Request to get the containers available.
4 changes: 2 additions & 2 deletions digicert-certcentral-anycagateway/API/ListDomains.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Keyfactor.Extensions.CAGateway.DigiCert.Models;
using Keyfactor.Extensions.CAPlugin.DigiCert.Models;
using Microsoft.VisualBasic;
using Newtonsoft.Json;

@@ -9,7 +9,7 @@
using System.Threading.Tasks;
using System.Web;

namespace Keyfactor.Extensions.CAGateway.DigiCert.API
namespace Keyfactor.Extensions.CAPlugin.DigiCert.API
{
public class ListDomainsRequest : CertCentralBaseRequest
{
4 changes: 2 additions & 2 deletions digicert-certcentral-anycagateway/API/ListDuplicates.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Keyfactor.Extensions.CAGateway.DigiCert.Models;
using Keyfactor.Extensions.CAPlugin.DigiCert.Models;

using Newtonsoft.Json;

@@ -8,7 +8,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.API
namespace Keyfactor.Extensions.CAPlugin.DigiCert.API
{
public class ListDuplicatesRequest : CertCentralBaseRequest
{
2 changes: 1 addition & 1 deletion digicert-certcentral-anycagateway/API/ListMetadata.cs
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.API
namespace Keyfactor.Extensions.CAPlugin.DigiCert.API
{
/// <summary>
/// Request to get the metadata fields available.
2 changes: 1 addition & 1 deletion digicert-certcentral-anycagateway/API/ListOrganizations.cs
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
using System.Threading.Tasks;
using System.Web;

namespace Keyfactor.Extensions.CAGateway.DigiCert.API
namespace Keyfactor.Extensions.CAPlugin.DigiCert.API
{
public class ListOrganizationsRequest : CertCentralBaseRequest
{
4 changes: 2 additions & 2 deletions digicert-certcentral-anycagateway/API/ListReissues.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Keyfactor.Extensions.CAGateway.DigiCert.Models;
using Keyfactor.Extensions.CAPlugin.DigiCert.Models;
using Newtonsoft.Json;

using System;
@@ -7,7 +7,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.API
namespace Keyfactor.Extensions.CAPlugin.DigiCert.API
{
public class ListReissueRequest : CertCentralBaseRequest
{
4 changes: 2 additions & 2 deletions digicert-certcentral-anycagateway/API/ListRequests.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Keyfactor.Extensions.CAGateway.DigiCert.Models;
using Keyfactor.Extensions.CAPlugin.DigiCert.Models;
using Newtonsoft.Json;

using System;
@@ -8,7 +8,7 @@
using System.Threading.Tasks;
using System.Web;

namespace Keyfactor.Extensions.CAGateway.DigiCert.API
namespace Keyfactor.Extensions.CAPlugin.DigiCert.API
{
public class ListRequestsRequest : CertCentralBaseRequest
{
4 changes: 2 additions & 2 deletions digicert-certcentral-anycagateway/API/OrderCertificate.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Keyfactor.Extensions.CAGateway.DigiCert.Models;
using Keyfactor.Extensions.CAPlugin.DigiCert.Models;
using Microsoft.VisualBasic;
using Newtonsoft.Json;

@@ -10,7 +10,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.API
namespace Keyfactor.Extensions.CAPlugin.DigiCert.API
{
public class OrderRequest : CertCentralBaseRequest
{
4 changes: 2 additions & 2 deletions digicert-certcentral-anycagateway/API/Reissue.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Keyfactor.Extensions.CAGateway.DigiCert.Models;
using Keyfactor.Extensions.CAPlugin.DigiCert.Models;
using Newtonsoft.Json;

using System;
@@ -7,7 +7,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.API
namespace Keyfactor.Extensions.CAPlugin.DigiCert.API
{
[Serializable]
public class ReissueRequest : CertCentralBaseRequest
2 changes: 1 addition & 1 deletion digicert-certcentral-anycagateway/API/RevokeCertificate.cs
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
using System.Threading.Tasks;
using System.Web;

namespace Keyfactor.Extensions.CAGateway.DigiCert.API
namespace Keyfactor.Extensions.CAPlugin.DigiCert.API
{
public class RevokeCertificateRequest : CertCentralBaseRequest
{
2 changes: 1 addition & 1 deletion digicert-certcentral-anycagateway/API/StatusChanges.cs
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.API
namespace Keyfactor.Extensions.CAPlugin.DigiCert.API
{
public class StatusChangesRequest : CertCentralBaseRequest
{
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.API
namespace Keyfactor.Extensions.CAPlugin.DigiCert.API
{
public class UpdateRequestStatusRequest : CertCentralBaseRequest
{
4 changes: 2 additions & 2 deletions digicert-certcentral-anycagateway/API/ViewCertificateOrder.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Keyfactor.Extensions.CAGateway.DigiCert.Models;
using Keyfactor.Extensions.CAPlugin.DigiCert.Models;
using Newtonsoft.Json;

using System;
@@ -7,7 +7,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.API
namespace Keyfactor.Extensions.CAPlugin.DigiCert.API
{
public class ViewCertificateOrderRequest : CertCentralBaseRequest
{
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
using Keyfactor.AnyGateway.Extensions;
using Keyfactor.Common;
using Keyfactor.Common.Exceptions;
using Keyfactor.Extensions.CAGateway.DigiCert.API;
using Keyfactor.Extensions.CAGateway.DigiCert.Client;
using Keyfactor.Extensions.CAGateway.DigiCert.Models;
using Keyfactor.Extensions.CAPlugin.DigiCert.API;
using Keyfactor.Extensions.CAPlugin.DigiCert.Client;
using Keyfactor.Extensions.CAPlugin.DigiCert.Models;
using Keyfactor.Logging;
using Keyfactor.PKI.Enums;

@@ -20,21 +20,21 @@

using static Keyfactor.PKI.PKIConstants.Microsoft;

using CertCentralConstants = Keyfactor.Extensions.CAGateway.DigiCert.Constants;
using CertCentralConstants = Keyfactor.Extensions.CAPlugin.DigiCert.Constants;

namespace Keyfactor.Extensions.CAGateway.DigiCert
namespace Keyfactor.Extensions.CAPlugin.DigiCert
{
public class CertCentralCAConnector : IAnyCAPlugin
public class CertCentralCAPlugin : IAnyCAPlugin
{
private CertCentralConfig _config;
private readonly ILogger _logger;
private ICertificateDataReader _certificateDataReader;

private Dictionary<int, string> DCVTokens { get; } = new Dictionary<int, string>();

public CertCentralCAConnector()
public CertCentralCAPlugin()
{
_logger = LogHandler.GetClassLogger<CertCentralCAConnector>();
_logger = LogHandler.GetClassLogger<CertCentralCAPlugin>();
}
public void Initialize(IAnyCAPluginConfigProvider configProvider, ICertificateDataReader certificateDataReader)
{
@@ -403,7 +403,7 @@
/// </summary>
/// <param name="caRequestID">The gateway request ID of the record to retrieve, in the format 'orderID-certID'</param>
/// <returns></returns>
public async Task<AnyCAPluginCertificate> GetSingleRecord(string caRequestID)

Check warning on line 406 in digicert-certcentral-anycagateway/CertCentralCAPlugin.cs

GitHub Actions / call-dotnet-build-and-release-workflow / dotnet-build-and-release

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 406 in digicert-certcentral-anycagateway/CertCentralCAPlugin.cs

GitHub Actions / call-dotnet-build-and-release-workflow / dotnet-build-and-release

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
{
_logger.MethodEntry(LogLevel.Trace);
// Split ca request id into order and cert id
@@ -497,7 +497,7 @@
/// </summary>
/// <returns></returns>
/// <exception cref="Exception"></exception>
public async Task Ping()

Check warning on line 500 in digicert-certcentral-anycagateway/CertCentralCAPlugin.cs

GitHub Actions / call-dotnet-build-and-release-workflow / dotnet-build-and-release

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 500 in digicert-certcentral-anycagateway/CertCentralCAPlugin.cs

GitHub Actions / call-dotnet-build-and-release-workflow / dotnet-build-and-release

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
{
_logger.MethodEntry(LogLevel.Trace);
if (!_config.Enabled)
@@ -539,7 +539,7 @@
/// <returns></returns>
/// <exception cref="COMException"></exception>
/// <exception cref="Exception"></exception>
public async Task<int> Revoke(string caRequestID, string hexSerialNumber, uint revocationReason)

Check warning on line 542 in digicert-certcentral-anycagateway/CertCentralCAPlugin.cs

GitHub Actions / call-dotnet-build-and-release-workflow / dotnet-build-and-release

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 542 in digicert-certcentral-anycagateway/CertCentralCAPlugin.cs

GitHub Actions / call-dotnet-build-and-release-workflow / dotnet-build-and-release

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
{
_logger.MethodEntry(LogLevel.Trace);
int orderId = Int32.Parse(caRequestID.Substring(0, caRequestID.IndexOf('-')));
@@ -599,7 +599,7 @@
/// <param name="cancelToken"></param>
/// <returns></returns>
/// <exception cref="Exception"></exception>
public async Task Synchronize(BlockingCollection<AnyCAPluginCertificate> blockingBuffer, DateTime? lastSync, bool fullSync, CancellationToken cancelToken)

Check warning on line 602 in digicert-certcentral-anycagateway/CertCentralCAPlugin.cs

GitHub Actions / call-dotnet-build-and-release-workflow / dotnet-build-and-release

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 602 in digicert-certcentral-anycagateway/CertCentralCAPlugin.cs

GitHub Actions / call-dotnet-build-and-release-workflow / dotnet-build-and-release

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
{
_logger.MethodEntry(LogLevel.Trace);

@@ -739,7 +739,7 @@
/// </summary>
/// <param name="connectionInfo"></param>
/// <returns></returns>
public async Task ValidateCAConnectionInfo(Dictionary<string, object> connectionInfo)

Check warning on line 742 in digicert-certcentral-anycagateway/CertCentralCAPlugin.cs

GitHub Actions / call-dotnet-build-and-release-workflow / dotnet-build-and-release

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 742 in digicert-certcentral-anycagateway/CertCentralCAPlugin.cs

GitHub Actions / call-dotnet-build-and-release-workflow / dotnet-build-and-release

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
{
_logger.MethodEntry(LogLevel.Trace);
try
@@ -810,7 +810,7 @@
/// <param name="connectionInfo"></param>
/// <returns></returns>
/// <exception cref="Exception"></exception>
public async Task ValidateProductInfo(EnrollmentProductInfo productInfo, Dictionary<string, object> connectionInfo)

Check warning on line 813 in digicert-certcentral-anycagateway/CertCentralCAPlugin.cs

GitHub Actions / call-dotnet-build-and-release-workflow / dotnet-build-and-release

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 813 in digicert-certcentral-anycagateway/CertCentralCAPlugin.cs

GitHub Actions / call-dotnet-build-and-release-workflow / dotnet-build-and-release

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
{
_logger.MethodEntry(LogLevel.Trace);
// Set up.
2 changes: 1 addition & 1 deletion digicert-certcentral-anycagateway/CertCentralConfig.cs
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert
namespace Keyfactor.Extensions.CAPlugin.DigiCert
{
public class CertCentralConfig
{
6 changes: 3 additions & 3 deletions digicert-certcentral-anycagateway/Client/CertCentralClient.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
using Keyfactor.Extensions.CAGateway.DigiCert.API;
using Keyfactor.Extensions.CAGateway.DigiCert.Models;
using Keyfactor.Extensions.CAPlugin.DigiCert.API;
using Keyfactor.Extensions.CAPlugin.DigiCert.Models;
using Keyfactor.Logging;
using Microsoft.Extensions.Logging;
using Newtonsoft.Json;
@@ -14,7 +14,7 @@

using static Keyfactor.PKI.X509.X509Utilities;

namespace Keyfactor.Extensions.CAGateway.DigiCert.Client
namespace Keyfactor.Extensions.CAPlugin.DigiCert.Client
{
public class CertCentralCredentials
{
@@ -97,7 +97,7 @@

Logger.LogTrace($"Entered CertCentral Request (ID: {reqID}) Method: {request.Method} - URL: {targetURI}");

HttpWebRequest objRequest = (HttpWebRequest)WebRequest.Create(targetURI);

Check warning on line 100 in digicert-certcentral-anycagateway/Client/CertCentralClient.cs

GitHub Actions / call-dotnet-build-and-release-workflow / dotnet-build-and-release

'WebRequest.Create(string)' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead.' (https://aka.ms/dotnet-warnings/SYSLIB0014)

Check warning on line 100 in digicert-certcentral-anycagateway/Client/CertCentralClient.cs

GitHub Actions / call-dotnet-build-and-release-workflow / dotnet-build-and-release

'WebRequest.Create(string)' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead.' (https://aka.ms/dotnet-warnings/SYSLIB0014)
objRequest.Method = request.Method;
objRequest.Headers.Add("X-DC-DEVKEY", this.CertCentralCreds.APIKey);

@@ -148,13 +148,13 @@
}
else
{
Logger.LogDebug("CertCentral Response Error", wex);

Check warning on line 151 in digicert-certcentral-anycagateway/Client/CertCentralClient.cs

GitHub Actions / call-dotnet-build-and-release-workflow / dotnet-build-and-release

Number of parameters supplied in the logging message template do not match the number of named placeholders (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2017)

Check warning on line 151 in digicert-certcentral-anycagateway/Client/CertCentralClient.cs

GitHub Actions / call-dotnet-build-and-release-workflow / dotnet-build-and-release

Number of parameters supplied in the logging message template do not match the number of named placeholders (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2017)
throw new Exception("Unable to establish connection to CertCentral web service", wex);
}
}
catch (Exception ex)
{
Logger.LogError("CertCentral Response Error", ex);

Check warning on line 157 in digicert-certcentral-anycagateway/Client/CertCentralClient.cs

GitHub Actions / call-dotnet-build-and-release-workflow / dotnet-build-and-release

Number of parameters supplied in the logging message template do not match the number of named placeholders (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2017)

Check warning on line 157 in digicert-certcentral-anycagateway/Client/CertCentralClient.cs

GitHub Actions / call-dotnet-build-and-release-workflow / dotnet-build-and-release

Number of parameters supplied in the logging message template do not match the number of named placeholders (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2017)
throw new Exception("Unable to establish connection to CertCentral web service", ex);
}

Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.Client
namespace Keyfactor.Extensions.CAPlugin.DigiCert.Client
{
/// <summary>
/// Static class containing some utility methods for the cert central client.
@@ -17,7 +17,7 @@ public static class CertCentralClientUtilities
/// <summary>
/// Private instance of the logger.
/// </summary>
private static ILogger Logger => LogHandler.GetClassLogger<CertCentralCAConnector>();
private static ILogger Logger => LogHandler.GetClassLogger<CertCentralCAPlugin>();

/// <summary>
/// Uses the <see cref="CertCentralConfig"/> to build a DigiCert client.
2 changes: 1 addition & 1 deletion digicert-certcentral-anycagateway/Client/Conversions.cs
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@
using System.Text.RegularExpressions;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.Client
namespace Keyfactor.Extensions.CAPlugin.DigiCert.Client
{
public class Conversions
{
2 changes: 1 addition & 1 deletion digicert-certcentral-anycagateway/Constants.cs
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert
namespace Keyfactor.Extensions.CAPlugin.DigiCert
{
public class Constants
{
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
using Keyfactor.Extensions.CAGateway.DigiCert.API;
using Keyfactor.Extensions.CAGateway.DigiCert.Client;
using Keyfactor.Extensions.CAPlugin.DigiCert.API;
using Keyfactor.Extensions.CAPlugin.DigiCert.Client;
using Keyfactor.Logging;
using Microsoft.Extensions.Logging;

@@ -9,7 +9,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.Models
namespace Keyfactor.Extensions.CAPlugin.DigiCert.Models
{
public class CertCentralCertType
{
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.Models
namespace Keyfactor.Extensions.CAPlugin.DigiCert.Models
{
public class CertificateOrder
{
2 changes: 1 addition & 1 deletion digicert-certcentral-anycagateway/Models/Contact.cs
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.Models
namespace Keyfactor.Extensions.CAPlugin.DigiCert.Models
{
public class User : Contact
{
2 changes: 1 addition & 1 deletion digicert-certcentral-anycagateway/Models/Error.cs
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.Models
namespace Keyfactor.Extensions.CAPlugin.DigiCert.Models
{
public class Error
{
2 changes: 1 addition & 1 deletion digicert-certcentral-anycagateway/Models/IdInformation.cs
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.Models
namespace Keyfactor.Extensions.CAPlugin.DigiCert.Models
{
public class IdInformation
{
2 changes: 1 addition & 1 deletion digicert-certcentral-anycagateway/Models/Product.cs
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.Models
namespace Keyfactor.Extensions.CAPlugin.DigiCert.Models
{
public class Product
{
2 changes: 1 addition & 1 deletion digicert-certcentral-anycagateway/Models/RequestSummary.cs
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@
using System.Text;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert.Models
namespace Keyfactor.Extensions.CAPlugin.DigiCert.Models
{
public class RequestSummary
{
2 changes: 1 addition & 1 deletion digicert-certcentral-anycagateway/Utilities.cs
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@
using System.Text.RegularExpressions;
using System.Threading.Tasks;

namespace Keyfactor.Extensions.CAGateway.DigiCert
namespace Keyfactor.Extensions.CAPlugin.DigiCert
{
public static class Utilities
{
Original file line number Diff line number Diff line change
@@ -2,10 +2,10 @@

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<RootNamespace>Keyfactor.Extensions.CAGateway.DigiCert</RootNamespace>
<RootNamespace>Keyfactor.Extensions.CAPlugin.DigiCert</RootNamespace>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>disable</Nullable>
<AssemblyName>DigicertCAGateway</AssemblyName>
<AssemblyName>DigicertCAPlugin</AssemblyName>
</PropertyGroup>

<ItemGroup>