(one more) portable c-char in dictionary.rs #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is one more pointer to fix. I overlooked it in my previous pull request: KeyviDev#250
narekgharibyan
approved these changes
Jun 30, 2022
|
Just an update here: Now we have many more CI jobs failing, so it seems something has changed, and may take a little while to get all fixed and get the package out. :( |
|
CI has been fixed, so I think it's safe to merge this PR. |
|
@narekgharibyan thank you! |
|
@y3ti |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one more pointer to fix. I overlooked it in my previous pull request:
#250
PS. May you release a new version with all latest changes?