Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lukka/run-cmake from 3 to 10 #279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 27, 2024

Bumps lukka/run-cmake from 3 to 10.

Release notes

Sourced from lukka/run-cmake's releases.

run-cmake@v10 - Support for CMakePreset.json

Changes:

  • Redesigned the inputs to support CMakePresets.json. All build/test process must be driven by the CMakePresets.json file, which ensures reproducible builds locally on your development machine, and remotely on build agents.
  • Simplified the codebase to make maintainability much easier with the following changes:
    • Dropped support for CMakeSettings.json, advanced and basic modes.
    • Dropped any http download of Ninja. The get-cmake action must be used instead.

run-cmake v3.3

Changes:

  • update the quickstart documentation to show how to properly use run-vcpkg and run-cmake to properly handle the vcpkg.json manifest file and cache the vcpkg artifacts.
  • consuming more recent version of dependencies.

Note: to keep your workflow up to date with bug and security fixes, just use v3 branch to stay on the most recent v3.x version of this action, e.g., uses: lukka/run-cmake@v3

Commits
  • 2ce8982 fix spacing in contributing.md
  • 1f075d1 - drop gulp.
  • 2f041fd Bump @​babel/traverse from 7.11.5 to 7.23.2
  • a65e42a Bump actions/checkout from 3 to 4
  • f73dfdf add codeql validation
  • 93b0f6c Bump actions/checkout from 3 to 4
  • fbcfe00 Bump word-wrap from 1.2.3 to 1.2.4
  • f9520b0 Bump semver from 5.7.1 to 5.7.2
  • c6e1f27 Bump tough-cookie from 4.1.2 to 4.1.3
  • c2b72af reword the README.md regarding VCPKG_ROOT env var.
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 27, 2024
@hendrikmuhs
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/github_actions/lukka/run-cmake-10 branch from c13cb1b to b95a3ac Compare January 27, 2024 17:03
@narekgharibyan
Copy link
Member

@dependabot rebase

Bumps [lukka/run-cmake](https://github.com/lukka/run-cmake) from 3 to 10.
- [Release notes](https://github.com/lukka/run-cmake/releases)
- [Commits](lukka/run-cmake@v3...v10)

---
updated-dependencies:
- dependency-name: lukka/run-cmake
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/github_actions/lukka/run-cmake-10 branch from b95a3ac to 6b6788c Compare February 19, 2024 13:08
@narekgharibyan
Copy link
Member

The error we get is:

Error: "Error: no preset has been specified in any of the inputs. Please provide at least the name of one preset.
    at CMakeRunner.<anonymous> (/home/runner/work/_actions/lukka/run-cmake/v10/dist/index.js:6787:23)
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/_actions/lukka/run-cmake/v10/dist/index.js:6700:58)
Error: run-cmake action execution failed: 'Error: "Error: no preset has been specified in any of the inputs. Please provide at least the name of one preset.'

And it is related to update to the 10th version. https://github.com/lukka/run-cmake?tab=readme-ov-file#run-cmakev10-runs-cmake-with-cmakepresetsjson

Honestly don't really know what presets are, but that is the missing thing here.

@hendrikmuhs
Copy link
Contributor

It asks us to commit a json file like this: https://cmake.org/cmake/help/latest/manual/cmake-presets.7.html#id4

It seems this is where cmake is heading towards. However it seems to require a larger refactoring/overhaul of the whole cmake configs.

I don't know how urgent this is, but github wants to get rid of node16 based actions and we are using a super old version of this action. We might realize one day that it suddenly stops working. It makes sense to do something about it.

Note, we have several options, e.g. it might be easier to jump to a reasonable recent version of this action before the introduction of this mandatory preset file(3 < x < 10). We could also drop this action and run cmake ourselves.

@narekgharibyan
Copy link
Member

Yeah, no strong opinion whether to use action, or run cmake ourself.
But prob it is worth to switch to some 3 < x < 10 version, and then see where to head after ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants