New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement prefix completion the new way #283

Closed

hendrikmuhs wants to merge 1 commit into KeyviDev:master from hendrikmuhs:prefix-completion-new-style

Contributor

hendrikmuhs commented Feb 4, 2024 •

edited

Loading

this implements prefix completion the new style using match iterator and being integrated in dictionary.

It doesn't replace the old one yet:

lacks fuzzy matching
doesn't short cut traversal based on weight(bounded weighted state traverser in the old implementation), see Expose minimum weight in state traverser for completion dictionaries #284
not yet integrated into python binding

before the PR gets huge, it still seems to be a good idea to re-implement it in steps, I will address the missing parts in follow up PRs


          implement prefix completion the new way

6c99a3d

hendrikmuhs added the enhancement label

hendrikmuhs mentioned this pull request

Expose minimum weight in state traverser for completion dictionaries #284

Closed

hendrikmuhs mentioned this pull request

Prefix completions with custom python filter #287

Merged

hendrikmuhs closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels