Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement multiword completions with fuzzy matching support #292

Merged
merged 10 commits into from
Mar 21, 2024
Merged

Implement multiword completions with fuzzy matching support #292

merged 10 commits into from
Mar 21, 2024

Conversation

hendrikmuhs
Copy link
Contributor

@hendrikmuhs hendrikmuhs commented Mar 8, 2024 •
edited
Loading

implement a fuzzy version of multiword completion matching. This change also fixes a couple of fuzzy completion matching issues and simplifies the distance matrix calculations.

Note:

  • the distance calculation for cases where fuzzy completions are combined with a character deletion, e.g. completing "finnite state"(note the double "n") to "finite state traverser", was totally broken
  • there was also a case where completions required the last character to be an exact match, not sure where this came from, but this can be handled by the caller

@hendrikmuhs hendrikmuhs force-pushed the new-mw-completion-fuzzy branch from eaf6528 to 48f2029 Compare March 15, 2024 16:53
@hendrikmuhs hendrikmuhs force-pushed the new-mw-completion-fuzzy branch from 48f2029 to d003e3c Compare March 18, 2024 14:05
@hendrikmuhs hendrikmuhs force-pushed the new-mw-completion-fuzzy branch from d003e3c to 7408ba9 Compare March 19, 2024 07:13
@hendrikmuhs hendrikmuhs marked this pull request as ready for review March 19, 2024 07:21
narekgharibyan
narekgharibyan approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@narekgharibyan narekgharibyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, glad seeing fixes on this front!

@hendrikmuhs hendrikmuhs merged commit a8162e8 into KeyviDev:master Mar 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narekgharibyan narekgharibyan narekgharibyan approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hendrikmuhs @narekgharibyan