Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix weight traversal for long keys. The state traverser did not corre… #293

Merged

Conversation

hendrikmuhs
Copy link
Contributor

fix weight traversal for long keys. The state traverser did not correctly report the inner weight for the long key optimization. The parent weight must be provided when getting outgoing states.

Fixes issues with completions for long keys

…ctly

reported the inner weight for the long key optimization. The parent weight
must be provided when getting outgoing states.
@hendrikmuhs
Copy link
Contributor Author

FYI There is a glitch between gh-runners and the setup-python action:

actions/setup-python#577

I have a hotfix on the dev branch, however hope the root cause gets fixed upstream soon.

Copy link

@iamkhav iamkhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Hendrik explained to me that previously parent weights were not stored after a certain depth in the graph to save memory.
With this optimized way as far as I understand, they are just being passed on parent nodes' function calls.

@hendrikmuhs hendrikmuhs merged commit ba1c697 into KeyviDev:master Mar 15, 2024
7 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants