Skip to content

Commit 226c137

Browse files
committed
subscription_list: Show muted streams as faded in streams list
Fixes: zulip#424
1 parent b9363d8 commit 226c137

File tree

2 files changed

+65
-21
lines changed

2 files changed

+65
-21
lines changed

lib/widgets/subscription_list.dart

+26-21
Original file line numberDiff line numberDiff line change
@@ -219,28 +219,33 @@ class SubscriptionItem extends StatelessWidget {
219219
},
220220
child: Row(crossAxisAlignment: CrossAxisAlignment.center, children: [
221221
const SizedBox(width: 16),
222-
Padding(
223-
padding: const EdgeInsets.symmetric(vertical: 11),
224-
child: Icon(size: 18, color: swatch.iconOnPlainBackground,
225-
iconDataForStream(subscription))),
226-
const SizedBox(width: 5),
227222
Expanded(
228-
child: Padding(
229-
padding: const EdgeInsets.symmetric(vertical: 10),
230-
// TODO(design): unclear whether bold text is applied to all subscriptions
231-
// or only those with unreads:
232-
// https://github.com/zulip/zulip-flutter/pull/397#pullrequestreview-1742524205
233-
child: Text(
234-
style: const TextStyle(
235-
fontSize: 18,
236-
height: (20 / 18),
237-
// TODO(#95) need dark-theme color
238-
color: Color(0xFF262626),
239-
).merge(weightVariableTextStyle(context,
240-
wght: hasUnreads ? 600 : null)),
241-
maxLines: 1,
242-
overflow: TextOverflow.ellipsis,
243-
subscription.name))),
223+
child: Opacity(
224+
opacity: subscription.isMuted ? 0.55 : 1,
225+
child: Row(
226+
children: [
227+
Padding(
228+
padding: const EdgeInsets.symmetric(vertical: 11),
229+
child: Icon(size: 18, color: swatch.iconOnPlainBackground,
230+
iconDataForStream(subscription))),
231+
const SizedBox(width: 5),
232+
Expanded(
233+
child: Padding(
234+
padding: const EdgeInsets.symmetric(vertical: 10),
235+
// TODO(design): unclear whether bold text is applied to all subscriptions
236+
// or only those with unreads:
237+
// https://github.com/zulip/zulip-flutter/pull/397#pullrequestreview-1742524205
238+
child: Text(
239+
style: const TextStyle(
240+
fontSize: 18,
241+
height: (20 / 18),
242+
// TODO(#95) need dark-theme color
243+
color: Color(0xFF262626),
244+
).merge(weightVariableTextStyle(context,
245+
wght: hasUnreads ? 600 : null)),
246+
maxLines: 1,
247+
overflow: TextOverflow.ellipsis,
248+
subscription.name)))]))),
244249
if (unreadCount > 0) ...[
245250
const SizedBox(width: 12),
246251
// TODO(#747) show @-mention indicator when it applies

test/widgets/subscription_list_test.dart

+39
Original file line numberDiff line numberDiff line change
@@ -202,4 +202,43 @@ void main() {
202202
check(tester.widget<UnreadCountBadge>(find.byType(UnreadCountBadge)).backgroundColor)
203203
.equals(swatch);
204204
});
205+
206+
testWidgets('muted streams are displayed as faded', (tester) async {
207+
final stream1 = eg.stream(name: 'Stream 1');
208+
final stream2 = eg.stream(name: 'Stream 2');
209+
final unreadMsgs = eg.unreadMsgs(streams: [
210+
UnreadStreamSnapshot(streamId: stream1.streamId, topic: 'a', unreadMessageIds: [1, 2]),
211+
UnreadStreamSnapshot(streamId: stream2.streamId, topic: 'b', unreadMessageIds: [3]),
212+
]);
213+
await setupStreamListPage(tester,
214+
subscriptions: [
215+
eg.subscription(stream1, isMuted: true),
216+
eg.subscription(stream2, isMuted: false)
217+
],
218+
userTopics: [
219+
UserTopicItem(
220+
streamId: stream1.streamId,
221+
topicName: 'a',
222+
lastUpdated: 1234567890,
223+
visibilityPolicy: UserTopicVisibilityPolicy.unmuted,
224+
),
225+
UserTopicItem(
226+
streamId: stream2.streamId,
227+
topicName: 'b',
228+
lastUpdated: 1234567890,
229+
visibilityPolicy: UserTopicVisibilityPolicy.unmuted,
230+
),
231+
],
232+
unreadMsgs: unreadMsgs);
233+
234+
final stream1Finder = find.text('Stream 1');
235+
final stream1Opacity = tester.widget<Opacity>(
236+
find.ancestor(of: stream1Finder, matching: find.byType(Opacity))).opacity;
237+
check(stream1Opacity).equals(0.55);
238+
239+
final stream2Finder = find.text('Stream 2');
240+
final stream2Opacity = tester.widget<Opacity>(
241+
find.ancestor(of: stream2Finder, matching: find.byType(Opacity))).opacity;
242+
check(stream2Opacity).equals(1.0);
243+
});
205244
}

0 commit comments

Comments
 (0)