Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aphrodite is a lightweight package for modular styles. That's why we love it.
But some things aren't modular:
The current best practice is to use something other than aphrodite for these cases (except in the case of fonts, where aphrodite has kinda hacky logic).
With a very small amount of code, we can support globals (including SSR).
Globals are actually very easy:
Why a 3rd party package doesn't work:
isBuffering
is private, which means the user must passinjectStyleOnce
to their function (otherwise you'd have 2 discrete flush cycles for the SSR). This is doable: see hepha. However, it'd be so much cleaner to include it in aphrodite as I'm sure everyone has a custom font, or{margin: 0}
body tag that they'd like to load properly 😄