Sort prefixed values before unprefixed values with the same key #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lencioni
approved these changes
Mar 8, 2017
| const prefixedDeclarations = prefixAll(handledDeclarations.elements); | ||
|
|
||
| const prefixedRules = flatten( | ||
| objectToPairs(prefixedDeclarations).map(([key, value]) => { |
There was a problem hiding this comment.
unrelated: I wonder if we should replace objectToPairs with Object.entries
src/generate.js
Outdated
| const aOrder = sortOrder.hasOwnProperty(a[0]) ? sortOrder[a[0]] : -1; | ||
| const bOrder = sortOrder.hasOwnProperty(b[0]) ? sortOrder[b[0]] : -1; | ||
| return aOrder - bOrder; | ||
| return sortOrderForProperty(a) - sortOrderForProperty(b); |
There was a problem hiding this comment.
nit: this could be simplified to use the implicit return style
Summary: In #200 the way we started sorting prefixed and unprefixed values differently. This builds on that by making sure that when style values are prefixed, they come before the unprefixed values with the same key. E.g. ```css display: -webkit-flex; // prefixed value comes before display: flex; // unprefixed value ``` @lencioni
xymostech
force-pushed
the
sort-prefixed-values
branch
from
57c70ce to
d8a629b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In #200 the way we started sorting prefixed and unprefixed values
differently. This builds on that by making sure that when style values are
prefixed, they come before the unprefixed values with the same key.
E.g.
@lencioni