Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make String Handlers Use useImportant #256

Merged
merged 1 commit into from
Jul 14, 2017
Merged

Make String Handlers Use useImportant #256

merged 1 commit into from
Jul 14, 2017

Commits on Jul 14, 2017

  1. Make String Handlers Use useImportant 

    The string handlers were always inserting rules with no `!important`, rather than respecting the settings specified by the library. This updates the string handlers to receive an additional `useImportant` argument, which is then passed down to the various places that need it (rather than just passing `false`). I updated the existing test, which was confirming the wrong input, and also added some more tests to `no-important_test.js` to confirm that it was still being disabled.

In practice this helps to fix the issue where Firefox makes it impossible to override CSS that has `!important` with an animation, unless the animation is, also, using `!important`:
http://tosbourn.com/firefox-honours-important-in-css-animations-no-one-else-seems-to/

Test Plan:
I ran `npm test` and it passed.
    @jeresig
    jeresig committed Jul 14, 2017
    Configuration menu
    Copy the full SHA
    51b08e5 View commit details
    Browse the repository at this point in the history