-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump inline-style-prefixer to 4.0.0 #297
Bump inline-style-prefixer to 4.0.0 #297
Conversation
Hey @calinoracation, Thanks for the PR! Mind signing our Contributor License Agreement? When you've done so, go ahead and comment Yours truly, |
[clabot:check] |
CLA signature looks good 👍 |
@rofrischmann how much of the performance improvement do you think comes from updating the default browser list vs other types of changes in v4? I wonder if it is worth allowing either v3 or v4 in the dependency range? |
It looks like the change for the 30% perf improvement was introduced in 3.0.2, but a potential bug in the ordering wasn't fixed until 4.0.0 in robinweser/inline-style-prefixer#147. |
I just ran the benchmarks from https://github.com/hellofresh/css-in-js-perf-tests as a first attempt at profiling the changes. Only the first set of unrepeated simple-tests so far, with 3 versions: 1.1.0aphrodite x 12,661 ops/sec ±2.82% (80 runs sampled)
aphrodite-no-important x 16,442 ops/sec ±1.67% (85 runs sampled) 1.2.5 (current published version)aphrodite x 26,762 ops/sec ±2.44% (82 runs sampled)
aphrodite-no-important x 28,347 ops/sec ±7.26% (80 runs sampled) My branch off of master w/ package updateaphrodite x 27,387 ops/sec ±1.31% (85 runs sampled)
aphrodite-no-important x 30,505 ops/sec ±0.69% (87 runs sampled) |
Nice, thanks for the numbers!
…On Tue, Feb 6, 2018, 12:46 AM Callie Callaway ***@***.***> wrote:
I just ran the benchmarks from
https://github.com/hellofresh/css-in-js-perf-tests as a first attempt at
profiling the changes. Only the first set of unrepeated simple-tests so
far, with 3 versions:
1.1.0
aphrodite x 12,661 ops/sec ±2.82% (80 runs sampled)
aphrodite-no-important x 16,442 ops/sec ±1.67% (85 runs sampled)
1.2.5 (current published version)
aphrodite x 26,762 ops/sec ±2.44% (82 runs sampled)
aphrodite-no-important x 28,347 ops/sec ±7.26% (80 runs sampled)
My branch off of master w/ package update
aphrodite x 27,387 ops/sec ±1.31% (85 runs sampled)
aphrodite-no-important x 30,505 ops/sec ±0.69% (87 runs sampled)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#297 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAL7zoE4GnLz4Nr63WPb7PNaCKuYmEg7ks5tSBFngaJpZM4R6X1C>
.
|
I'll add more extensive ones that use puppeteer and can be run directly from this repo in a follow-up PR, just wanted to post a few initial numbers! |
Awesome!
…On Tue, Feb 6, 2018, 12:14 PM Callie Callaway ***@***.***> wrote:
I'll add more extensive ones that use puppeteer and can be run directly
from this repo in a follow-up PR, just wanted to post a few initial numbers!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#297 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAL7ztbKeoh3D1Ww6i-hXd3Gn7ZnxqKcks5tSLKcgaJpZM4R6X1C>
.
|
This bumps the version of inline-style-prefixer to pick up the bug fixes and performance improvements introduced since 3.0.1, which includes a reported 30% improvement. From what I can tell, the major version bump was due to them changing their default browser prefix list, which we specify our own in https://github.com/Khan/aphrodite/blob/master/tools/generate_prefixer_data.js so I don't believe that will be an issue. https://github.com/rofrischmann/inline-style-prefixer/blob/master/Changelog.md