Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typings to resolve #329 #330

Merged
merged 1 commit into from
Jun 8, 2018
Merged

Update typings to resolve #329 #330

merged 1 commit into from
Jun 8, 2018

Conversation

Sibz
Copy link
Contributor

@Sibz Sibz commented May 28, 2018 •
edited by lencioni
Loading

exported StyleSheetStatic

Moved extend method definition into first StyleSheetStatic interface definition + removed second StyleSheetStatic definition

Fixes #329

@khanbot
Copy link

khanbot commented May 28, 2018

Hey @Sibz,

Thanks for the PR! Mind signing our Contributor License Agreement?

When you've done so, go ahead and comment [clabot:check] and I'll check again.

Yours truly,
khanbot

@Sibz
Copy link
Contributor Author

Sibz commented May 28, 2018

[clabot:check]

@khanbot
Copy link

khanbot commented May 28, 2018

CLA signature looks good 👍

@Sibz Sibz force-pushed the fix-for-StyleSheetStatic-not-exported branch from 662d541 to bb13741 Compare May 28, 2018 16:37
@lencioni lencioni requested a review from jlfwong June 7, 2018 16:17
@lencioni
Copy link
Collaborator

lencioni commented Jun 7, 2018

@dmiller9911 Can you please review this when you have a chance?

dmiller9911
dmiller9911 approved these changes Jun 8, 2018
View reviewed changes
Copy link
Contributor

@dmiller9911 dmiller9911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice catch on the dual StyleSheetStatic interfaces.

@lencioni lencioni merged commit 8df7404 into Khan:master Jun 8, 2018
@Sibz Sibz deleted the fix-for-StyleSheetStatic-not-exported branch June 9, 2018 10:27
@dependencies dependencies bot mentioned this pull request Jun 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmiller9911 dmiller9911 dmiller9911 approved these changes

@jlfwong jlfwong Awaiting requested review from jlfwong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sibz @khanbot @lencioni @dmiller9911