-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable buffer methods before needing to call StyleSheetServer.renderStatic #342
base: master
Are you sure you want to change the base?
Conversation
… Aphrodite cannot be the last call before renderToStatic
Hey @DaBs, Thanks for the PR! Mind signing our Contributor License Agreement? When you've done so, go ahead and comment Yours truly, |
[clabot:check] |
CLA signature looks good 👍 |
@jlfwong Is this something you know if people within the project has time to look at? I believe it's quite a nice way of giving some manual tools for people to be able to temporarily suspend aphrodite style rendering when it comes to SSR. |
I'm running into this issue as well! Any chance this will be merged & released any time soon? :) |
Y'all, this has been an issue for quite a long time now... |
Man, I has a problems that this PR will resolve. Has plans to merge it? The problem is the below:
@jlfwong can you help us? |
Currently, Aphrodite assumes that it is the first server-side module to render the tree, but
since
StyleSheetServer.renderStatic
expects a string as return value, it eliminates any possibility of walking the reference with another module.This PR borrows some of the TestUtils functions to allow a, albeit a bit clunky, method of avoiding having to append classes to the DOM while walking an existing reference to a tree.