Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flow syntax #397

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Update flow syntax #397

wants to merge 11 commits into from

Conversation

Brianzchen
Copy link
Contributor

This change is all about maintaining the flowtype code.

  • Update to latest version so that it can be maintained easier and also allows LSP mode
  • Update flow config for best practice warnings including ambiguous-object-type which ensures as a library we explicitly define objects as exact/inexact for if flow types are exposed in the future
  • Fix all flow errors from upgrading flow version, no logic has been changed
  • Migrate from flow comment syntax to regular syntax and stripping with @babel/preset-flow. After upgrading there were syntax errors raised by flow in the dist file. Doing this removes the errors and makes the project easier to maintain
  • All src files are now flow typed which will help in future flow exposure

@lencioni @jlfwong

@Brianzchen
Copy link
Contributor Author

Added a new line to travis.yml. The example dir never ran npm install during the build which was fine because it's only imports were react and react-dom. But react-dom has since had it's definitions removed from flow and into flow-typed which caused errors during flow check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant