Skip to content

Commit

Permalink
Improve HTTP error text
Browse files Browse the repository at this point in the history
Thanks to Craig for the suggestion! Since people may have, before #363,
been parsing the text, I mentioned it as a breaking change, although I
imagine most people are parsing just the code.
  • Loading branch information
benjaminjkraft committed Nov 30, 2024
1 parent 800909d commit 3c2f9e4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions docs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ When releasing a new version:

- omitempty validation:
- forbid `omitempty: false` (including implicit behaviour) when using pointer on non-null input field
- The error text for HTTP errors has changed slightly. If you were parsing it, switch to [`As`-ing to `graphql.HTTPError`](client_config.md#handling-errors)_.

### New features:

Expand Down
2 changes: 1 addition & 1 deletion graphql/errors.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ type HTTPError struct {

// Error implements the error interface for HTTPError.
func (e *HTTPError) Error() string {
return fmt.Sprintf("returned error %v: %s", e.StatusCode, e.Body)
return fmt.Sprintf("returned error %v: '%s'", e.StatusCode, e.Body)
}

0 comments on commit 3c2f9e4

Please sign in to comment.