Skip to content

Commit

Permalink
Clean up a no-longer-relevant comment, and fix a typo
Browse files Browse the repository at this point in the history
  • Loading branch information
benjaminjkraft committed Aug 30, 2021
1 parent d08d51e commit b5c7b5c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
11 changes: 0 additions & 11 deletions generate/convert.go
Original file line number Diff line number Diff line change
Expand Up @@ -248,17 +248,6 @@ func (g *generator) convertDefinition(
g.typeMap[name] = goType

for i, implDef := range implementationTypes {
// Note for shared fields we propagate forward the interface's
// name-prefix: that is, the implementations will have fields with
// types like
// MyInterfaceMyFieldMyType
// not
// MyInterfaceMyImplMyFieldMyType
// ^^^^^^
// In particular, this means that the Go type of MyField will be
// the same across all the implementations; this is important so
// that we can write a method GetMyField() that returns it!
// STOPSHIP: update all this nonsense
// TODO(benkraft): In principle we should skip generating a Go
// field for __typename each of these impl-defs if you didn't
// request it (and it was automatically added by
Expand Down
2 changes: 1 addition & 1 deletion generate/names.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ package generate
// value of consistency seems greater than the value of brevity, given the
// types are quite verbose either way. Note that in all cases the "MyField" is
// the alias of the field -- the name it has in this query -- since you could
// have `query Q { a: f { b }, c: f { d } }` and Q.A and Q.B must have
// have `query Q { a: f { b }, c: f { d } }` and Q.A and Q.C must have
// different types.
//
// One subtlety in the above description is: is the "MyType" the interface or
Expand Down

0 comments on commit b5c7b5c

Please sign in to comment.