Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lowercase the error massage, because go-staticcheck complains with ST1005 #202

Closed
rdanchev opened this issue May 31, 2022 · 1 comment · Fixed by #213
Closed

Lowercase the error massage, because go-staticcheck complains with ST1005 #202

rdanchev opened this issue May 31, 2022 · 1 comment · Fixed by #213
Labels
help wanted Issues that anyone could pick up and implement if useful to them

Comments

@rdanchev
Copy link

error strings should not be capitalized (ST1005) go-staticcheck

genqlient/generate/unmarshal.go.tmpl

Line 142 in 37fa3d6

"Unable to unmarshal {{$.GoName}}.{{$field.GoName}}: %w", err)

@benjaminjkraft
Copy link
Collaborator

Thanks for the report; PRs are welcome for this sort of thing but please note that we do not intend for generated code to be lint-clean according to any particular style tool: linters enforce many guidelines that make sense for human-written code but not necessarily for generated code.

@benjaminjkraft benjaminjkraft added the help wanted Issues that anyone could pick up and implement if useful to them label Jun 1, 2022
breml added a commit to bremlforks/genqlient that referenced this issue Aug 4, 2022
@breml
Fix incorrectly formatted error string
c2b4b96 
Follow best practices from Go Review Comments:
https://github.com/golang/go/wiki/CodeReviewComments#error-strings

Closes: Khan#202
@breml breml mentioned this issue Aug 4, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issues that anyone could pick up and implement if useful to them
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrectly formatted error string bremlforks/genqlient
2 participants
@benjaminjkraft @rdanchev