Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate slices containing all enum values #350

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Generate slices containing all enum values #350

merged 1 commit into from
Aug 19, 2024

Conversation

Zhenya750
Copy link
Contributor

It would be useful to generate slices containing all enum values for each enum type. Then there will be no need to maintain such kind of slices manually.

I have:

  • Written a clear PR title and description (above)
  • Signed the Khan Academy CLA
  • Added tests covering my changes, if applicable
  • Included a link to the issue fixed, if applicable
  • Included documentation, for new features
  • Added an entry to the changelog

benjaminjkraft
benjaminjkraft approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@benjaminjkraft benjaminjkraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great! Thanks for the PR!

@benjaminjkraft benjaminjkraft merged commit 4466fc1 into Khan:main Aug 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminjkraft benjaminjkraft benjaminjkraft approved these changes

@csilvers csilvers Awaiting requested review from csilvers csilvers is a code owner

@dnerdy dnerdy Awaiting requested review from dnerdy dnerdy is a code owner

@StevenACoffman StevenACoffman Awaiting requested review from StevenACoffman StevenACoffman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zhenya750 @benjaminjkraft