chore: GitHub upgrades and allow arguments

[shanegenschaw]

GitHub upgrades

Upgrades for deprecated GitHub Actions functionality:

• 2022-10-11-github-actions-deprecating-save-state-and-set-output-commands
• 2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12

This PR basically combines the following PRs, but adds a necessary rebuild of the ./dist/index.js file:

• update nodejs version from 12 to 16 #36
• chore: Bump @actions/core #37

Resolves:

• Update action to use node16 instead of node12 #35
• The set-output command is deprecated and will be disabled soon #40

Allow arguments

Contribution from @shpingalet007 to allow parsing arguments from the comment body.

Changes

1. Added GitHub Actions input - allow_arguments: Boolean. It enables/disables arguments parsing. It is set to false by default.
2. Arguments parsing via double-asterisk marker - script looks for ** in trigger and considers the marked part of the comment as argument. Output to the steps.check.outputs.arguments. It doesn't do anything if allow_arguments: false.
3. Add new example - add job that enables debugging #deploy on ** environment comment.

Other changes

• Replace npm @zeit/ncc to @vercel/ncc as it was deprecated.
• Upload new action NCC build.
• Documented everything in Readme.md.

Related PRs:

• Arguments parsing implementation #34
• Merging contribution from shpingalet007 to allow arguments  shanegenschaw/pull-request-comment-trigger#3

[shanegenschaw]

The updated action is published in the marketplace if anyone wants to use it until this repo gets patched.

[shpingalet007]

@shanegenschaw would you like to merge my PR #34 in your fork? Mentioned your fork on #34 (comment)

[shanegenschaw]

@shanegenschaw would you like to merge my PR #34 in your fork? Mentioned your fork on #34 (comment)

@shpingalet007 sure I will try to work on this asap

[shanegenschaw]

@shanegenschaw would you like to merge my PR #34 in your fork? Mentioned your fork on #34 (comment)

PR is ready here if you wouldn't mind having a look @shpingalet007 : shanegenschaw#3

[shpingalet007]

Okay, done @shanegenschaw! Thanks 🤝 Btw, why is this a PR instead of issue?)

[shanegenschaw]

The work from @shpingalet007 has been merged in with this PR and published as v2 and v2.1.0

[ramiro]

Checking for prefixOnly here is superfluous. Can be rewritten to

if (!hasTrigger) {

[shpingalet007]

Related to PR #34. Would check this soon and apply there as this PR is duplicate. Thanks!

[shpingalet007]

Okay, took a look at that @ramiro.

Finally, removing prefixOnly everywhere as the functionality is not stable if trigger is somewhere in the middle of comment. Commit 8963ccd. The condition was changed to the suggested too as there is no need in prefixOnly.

As this is duplicate PR, I suppose the issue must be resolved here or this PR must be closed before this review can be resolved. Anyway, the original PR is fixed. Thanks for your suggestions, and if you have more related to arguments parsing, consider publishing them in #34.

[ramiro]

@shpingalet007 can you share more details of the kind of problems the prefix_only option introduces?

I've had cases of the official action from this repository master at the f8ab347 commit failing randomly to detect the comment keyword and I want to understand if this could be the reason.

[shpingalet007]

@shanegenschaw this PR is duplicate of #34, #36, #37. If there are no reasons to keep it, the work must be proceeded there.