Skip to content
This repository has been archived by the owner on May 18, 2023. It is now read-only.

Commit

Permalink
[FEI-2995] Logging enhancements and fixes (#455)
Browse files Browse the repository at this point in the history
## Summary:
Two main changes here.

1. JSDOM console logging is now passed through to the render-gateway logging at the `silly` level. This avoids logging things we don't need in production, but supports them being available for devs as needed.
2. Fixes an issue where we started seeing some double logging  and low level logging in production. Turns out that logging-winston has a fix for a bug we were working around, and this fix meant that our workaround started behaving like the original bug. So, we remove the workaround and now all is well.

Issue: FEI-2995

## Test plan:
`yarn test`

After deployment (staging or otherwise) we should no longer see any `TRACE` messages for downloading files, and we shouldn't see any JSDOM console warn/info/debug/log output (though these are relatively uncommon now).

Author: somewhatabstract

Reviewers: somewhatabstract, jeresig, kevinbarabash

Required Reviewers: 

Approved by: jeresig, kevinbarabash

Checks: ✅ Test (macOS-latest, 12.x), ✅ Test (macOS-latest, 10.x), ✅ Test (ubuntu-latest, 10.x), ✅ Coverage (ubuntu-latest, 12.x), ✅ Publish to branch, ✅ Lint and flow check (ubuntu-latest, 12.x), ⏭  Auto-approve dependabot PRs

Pull request URL: #455
  • Loading branch information
somewhatabstract authored Mar 24, 2021
1 parent f9e6a31 commit 2769efc
Show file tree
Hide file tree
Showing 15 changed files with 129 additions and 159 deletions.
47 changes: 26 additions & 21 deletions dist/gateway/environments/jsdom-sixteen/create-virtual-console.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions dist/shared/create-logger.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 2769efc

Please sign in to comment.