This repository has been archived by the owner on May 18, 2023. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
## Summary: Two main changes here. 1. JSDOM console logging is now passed through to the render-gateway logging at the `silly` level. This avoids logging things we don't need in production, but supports them being available for devs as needed. 2. Fixes an issue where we started seeing some double logging and low level logging in production. Turns out that logging-winston has a fix for a bug we were working around, and this fix meant that our workaround started behaving like the original bug. So, we remove the workaround and now all is well. Issue: FEI-2995 ## Test plan: `yarn test` After deployment (staging or otherwise) we should no longer see any `TRACE` messages for downloading files, and we shouldn't see any JSDOM console warn/info/debug/log output (though these are relatively uncommon now). Author: somewhatabstract Reviewers: somewhatabstract, jeresig, kevinbarabash Required Reviewers: Approved by: jeresig, kevinbarabash Checks: ✅ Test (macOS-latest, 12.x), ✅ Test (macOS-latest, 10.x), ✅ Test (ubuntu-latest, 10.x), ✅ Coverage (ubuntu-latest, 12.x), ✅ Publish to branch, ✅ Lint and flow check (ubuntu-latest, 12.x), ⏭ Auto-approve dependabot PRs Pull request URL: #455
- Loading branch information