Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

khiops_env --env Execution Error is Not (Properly) Handled #300

Closed
popescu-v opened this issue Nov 28, 2024 · 0 comments · Fixed by #315
Closed

khiops_env --env Execution Error is Not (Properly) Handled #300

popescu-v opened this issue Nov 28, 2024 · 0 comments · Fixed by #315
Assignees
Labels
Status/Done The issue has been addressed and merged to the dev branch Type/Bug A malfunction of the library
Milestone

Comments

@popescu-v
Copy link
Collaborator

Description

Currently, khiops_env --env is executed with the appropriate path to the script, but only stdout is captured. Neither stderr, nor returncode are captured and handled.

Thus, if khiops_env --env fails for some reason (see e.g. KhiopsML/khiops#444, most notably comment KhiopsML/khiops#444 (comment)), there is no hint provided to the user. Just that the environment would not be set, which would entail failure later on.

Questions/Ideas

  • The solution is to capture stderr and .returncode from the khiops_env --env subprocess in _initialize_khiops_environment, so that the relevant KhiopsEnvironmentError is raised, with the message contained in the process' stderr.
@popescu-v popescu-v added Type/Bug A malfunction of the library Priority/0-High To do now Size/Hours Very short labels Nov 28, 2024
@popescu-v popescu-v added this to the 10.2.4.0 milestone Nov 28, 2024
@popescu-v popescu-v self-assigned this Nov 28, 2024
@folmos-at-orange folmos-at-orange added the Status/ReadyForDev The issue is ready to be developed or to be investigated deeply label Dec 12, 2024
@popescu-v popescu-v linked a pull request Dec 18, 2024 that will close this issue
3 tasks
@popescu-v popescu-v added Status/InDevelopment The issue is in development by one or more team members and removed Status/ReadyForDev The issue is ready to be developed or to be investigated deeply labels Dec 18, 2024
@folmos-at-orange folmos-at-orange added Status/Done The issue has been addressed and merged to the dev branch and removed Status/InDevelopment The issue is in development by one or more team members Priority/0-High To do now Size/Hours Very short labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status/Done The issue has been addressed and merged to the dev branch Type/Bug A malfunction of the library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants