239 Add support for python 3.13 #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tramora
force-pushed
the
support_python_3.13
branch
from
da32bff to
689ffac
Compare
tramora
force-pushed
the
support_python_3.13
branch
4 times, most recently
from
047cd08 to
1c64d50
Compare
tramora
requested review from
folmos-at-orange and
popescu-v
and removed request for
folmos-at-orange
tramora
force-pushed
the
support_python_3.13
branch
from
1c64d50 to
8862ca4
Compare
folmos-at-orange
approved these changes
Nov 18, 2024
tramora
force-pushed
the
support_python_3.13
branch
from
61c9194 to
05b7fe4
Compare
Commit message fixed. |
tramora
force-pushed
the
support_python_3.13
branch
from
05b7fe4 to
6d54a33
Compare
added 2 commits
November 19, 2024 11:17
Build & release are still done against python 3.12
Remove the obsolete macos-12 environment and add the new macos-15 one.
tramora
force-pushed
the
support_python_3.13
branch
from
6d54a33 to
1f9d475
Compare
popescu-v
reviewed
Nov 19, 2024
Comment on lines
+45
to
+46
| /root/miniforge3/bin/conda create -y -n py${version} python=${version} setuptools; \ | ||
| /root/miniforge3/bin/conda create -y -n py${version}_conda python=${version} setuptools; \ |
There was a problem hiding this comment.
I would have added separate conda install -y -n ... setuptools lines, so that the supplemental (new) installation of setuptools is launched in a separate line and instruction.
popescu-v
reviewed
Nov 19, 2024
| @@ -41,8 +41,9 @@ RUN true \ | |||
| ARG PYTHON_VERSIONS | |||
| RUN /bin/bash -c 'for version in ${PYTHON_VERSIONS}; \ | |||
| do \ | |||
| /root/miniforge3/bin/conda create -y -n py${version} python=${version}; \ | |||
| /root/miniforge3/bin/conda create -y -n py${version}_conda python=${version}; \ | |||
| # setuptools is a strong requirement for khiops-python. Force its installation because it is omitted since python 3.13 | |||
There was a problem hiding this comment.
The Dockerfile.rocky should also be updated with this IMHO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #239