Eliminate is_fitted_ sklearn attribute #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folmos-at-orange
force-pushed
the
273-eliminate-is_fitted_-sklearn-attribute
branch
5 times, most recently
from
68850a3 to
d2595f1
Compare
folmos-at-orange
force-pushed
the
273-eliminate-is_fitted_-sklearn-attribute
branch
from
d2595f1 to
66dc651
Compare
folmos-at-orange
force-pushed
the
273-eliminate-is_fitted_-sklearn-attribute
branch
2 times, most recently
from
dc12f61 to
19e05f2
Compare
folmos-at-orange
force-pushed
the
273-eliminate-is_fitted_-sklearn-attribute
branch
from
19e05f2 to
1477896
Compare
popescu-v
reviewed
Jan 7, 2025
popescu-v
reviewed
Jan 7, 2025
popescu-v
reviewed
Jan 7, 2025
folmos-at-orange
force-pushed
the
273-eliminate-is_fitted_-sklearn-attribute
branch
from
1477896 to
0c9fb9f
Compare
popescu-v
reviewed
Jan 8, 2025
| @@ -2704,3 +2706,25 @@ def test_khiops_encoder_no_output_variables_implies_not_fit(self): | |||
|
|
|||
| # Check that the encoder is not fit | |||
| self.assertNotFit(khe) | |||
|
|
|||
| def test_export_operations_raise_when_not_fitted(self): | |||
| """Test that export functions raise NonFittedError exceptions when non-fitted | |||
There was a problem hiding this comment.
s/NonFittedError/NotFittedError/ (Not instead of Non)
popescu-v
approved these changes
Jan 8, 2025
folmos-at-orange
force-pushed
the
273-eliminate-is_fitted_-sklearn-attribute
branch
from
0c9fb9f to
0b1671d
Compare
folmos-at-orange
deleted the
273-eliminate-is_fitted_-sklearn-attribute
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 720d30a (HEAD -> 273-eliminate-is_fitted_-sklearn-attribute, origin/273-eliminate-is_fitted_-sklearn-attribute)
Author: Felipe Olmos 92923444+folmos-at-orange@users.noreply.github.com
Date: Mon Nov 18 17:05:40 2024 +0100
commit af11895
Author: Felipe Olmos 92923444+folmos-at-orange@users.noreply.github.com
Date: Mon Nov 18 16:42:04 2024 +0100