Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update samples for dataset samples 10.2.4 #303

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Update samples for dataset samples 10.2.4 #303

merged 2 commits into from
Dec 11, 2024

Conversation

folmos-at-orange
Copy link
Member

@folmos-at-orange folmos-at-orange commented Dec 9, 2024 •
edited
Loading

TODO Before Asking for a Review

  • Rebase your branch to the latest version of dev (or main for release PRs)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

@folmos-at-orange folmos-at-orange force-pushed the update-samples branch 10 times, most recently from 83d202b to f16870a Compare December 10, 2024 17:00
@folmos-at-orange folmos-at-orange force-pushed the update-samples branch 4 times, most recently from 44c918e to 381fbde Compare December 11, 2024 09:46
@folmos-at-orange folmos-at-orange self-assigned this Dec 11, 2024
@folmos-at-orange folmos-at-orange added this to the 10.2.4.0 milestone Dec 11, 2024
popescu-v
popescu-v reviewed Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments:

  • an improvement suggestion
  • a request for qualification.

popescu-v
popescu-v approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but branch HEAD (commit 2bc757b) should be removed before merging this PR. To do this, the tutorials branch needs to be merged before as well, so that the CI of the current PR is green w/o this commit.

@folmos-at-orange folmos-at-orange merged commit 20f8d48 into dev Dec 11, 2024
19 checks passed
@folmos-at-orange folmos-at-orange deleted the update-samples branch December 11, 2024 15:48
@folmos-at-orange
Copy link
Member Author

LGTM, but branch HEAD (commit 2bc757b) should be removed before merging this PR. To do this, the tutorials branch needs to be merged before as well, so that the CI of the current PR is green w/o this commit.

  • Updated khiops-python-tutorial
  • Eliminated TMP commit
  • Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popescu-v popescu-v popescu-v approved these changes

Assignees

@folmos-at-orange folmos-at-orange

Labels
None yet
Projects
None yet
Milestone
10.2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@folmos-at-orange @popescu-v