Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid pandas warning in samples when reading Accidents/Places table #344

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Avoid pandas warning in samples when reading Accidents/Places table #344

merged 2 commits into from
Feb 6, 2025

Conversation

folmos-at-orange
Copy link
Member

@folmos-at-orange folmos-at-orange commented Feb 5, 2025 •
edited by popescu-v
Loading

Closes #342.

TODO Before Asking for a Review

  • Rebase your branch to the latest version of dev (or main for release PRs)
  • Make sure all CI workflows are green
  • Self-Review: Review "Files Changed" tab and fix any problems you find

@folmos-at-orange folmos-at-orange force-pushed the 342-eliminate-pandas-warning-in-samples branch from 77359a9 to dd260e8 Compare February 5, 2025 14:21
@popescu-v
Copy link
Collaborator

Commit ce0779b should be removed IMHO, as the necessary changes have already been backported to dev-v10. And this commit alone introduces a regression on PR templates (on dev if was followed by a partial revert to remedy).

@popescu-v popescu-v linked an issue Feb 5, 2025 that may be closed by this pull request
Eliminate pandas warning in samples #342
Closed
@folmos-at-orange folmos-at-orange force-pushed the 342-eliminate-pandas-warning-in-samples branch from dd260e8 to ba93d68 Compare February 5, 2025 15:53
@folmos-at-orange folmos-at-orange self-assigned this Feb 5, 2025
@folmos-at-orange folmos-at-orange force-pushed the 342-eliminate-pandas-warning-in-samples branch from ba93d68 to b7b5f54 Compare February 5, 2025 17:57
popescu-v
popescu-v approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@folmos-at-orange folmos-at-orange merged commit 42957ea into dev-v10 Feb 6, 2025
19 checks passed
@folmos-at-orange folmos-at-orange deleted the 342-eliminate-pandas-warning-in-samples branch February 6, 2025 08:59
@folmos-at-orange folmos-at-orange mentioned this pull request Feb 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popescu-v popescu-v popescu-v approved these changes

Assignees

@folmos-at-orange folmos-at-orange

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eliminate pandas warning in samples
2 participants
@folmos-at-orange @popescu-v